-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to actions/upload-artifact@v4
#140
Conversation
@@ -85,7 +85,7 @@ runs: | |||
|
|||
- id: upload-logs | |||
if: ${{ inputs.debug == 'true' }} | |||
uses: actions/upload-artifact@v3 | |||
uses: actions/upload-artifact@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not totally aware of what other changes need to be made. Haven't read the migration process docs yet. But this is causing all use of this Action to fail in CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly for the purposes of fixing this issue might be totally viable to just delete this entire Step. Most folks probably not running in Debug mode. Can add later and adjust params as needed for v4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just forked this Action and unblocked ourselves. Seems this Action does not require any special publish/build process for it to work 🎉
Edit: It does, but the binaries are committed to source and the change to fix this is just in yaml-land, so just forking the Action and pointing to it works just fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That alone should be enough, I think.
Uploaded artifacts are now immutable, so if you try to upload two with the same names in the same pipeline, previously it would have updated the files and now it won't. But this action isn't trying to do that, so I think it should just work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maschwenk for the PR and you are correct, this should just be a YAML update. I can publish a new package tonight once I am off of work. I may just pull this entirely in the future to minimize dependencies and the fact that it isn't being leveraged a whole lot.
actions/upload-artifact@v3
actions/upload-artifact@v4
When is this going to be merged this is breaking our CI as well! |
See the conversation thread above for an immediate fix. Note, that this a project I have had to solely maintain in my personal time and doesn't have a business sponsor. Although I am appealing to have others help as well so we can get multiple eyes. https://github.com/awalsh128/cache-apt-pkgs-action?tab=readme-ov-file#cache-apt-pkgs-action |
Thanks @awalsh128 for the quick fix 🙏 |
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/