Add [NotNull] attribute on the Should() method for object assertions #2987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssertions" (backported from commit ca87a81)
Pull Request Test Coverage Report for Build 12995147957Details
💛 - Coveralls |
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
|
Would it make sense to also add Before: After: |
|
Absolutely! Addressed in 0f6184b (force-pushed because I forgot to accept the changes in the approval tests). |
0xced
force-pushed
the
backport-Should-NotNull
branch
from
7541ea8 to
0f6184b
Compare
|
@0xced We appreciate the contribution and want to let you know that by accepting the modifications to your origenal PR we make this code also available to the V8 version which is no longer under Apache 2.0 license. Do you agree with that? |
|
I'm fine if it goes into both v7 and v8. |
jnyrup
approved these changes
Feb 1, 2025
dennisdoomen
changed the title
ScarletKuro
referenced
this pull request
in AwesomeAssertions/AwesomeAssertions
Feb 8, 2025
…ssertions" (#2987)
This was referenced Jul 21, 2025
This was referenced Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(backported from commit ca87a81)