Content-Length: 241128 | pFad | https://redirect.github.com/nodejs/readable-stream/pull/544

A2 fix: `internalStreamsWeakHandler` replacement rule by natebuckareff · Pull Request #544 · nodejs/readable-stream · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: internalStreamsWeakHandler replacement rule #544

Conversation

natebuckareff
Copy link
Contributor

The replacement part of the rule incorrectly contains the escape \\, probably copy-pasted from the pattern part. Fix is to just remove it.

The replacement part of the rule incorrectly contains the escape `\\`,
probably copy-pasted from the pattern part of the rule. Fix is to just
remove it.
@natebuckareff natebuckareff marked this pull request as ready for review November 30, 2024 03:57
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 837ec9e into nodejs:main Dec 18, 2024
98 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://redirect.github.com/nodejs/readable-stream/pull/544

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy