YAPF -> Black, drop py36 and async_generator, test on newer Pythons
#129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
general-maintenance
branch
from
edcc792 to
f788fe7
Compare
|
I'm not sure what's happened to |
pquentin
approved these changes
Oct 31, 2022
| @@ -1,2 +1,2 @@ | |||
| [pytest] | |||
| addopts = -W error -ra -v --pyargs pytest_trio --verbose --cov | |||
There was a problem hiding this comment.
What was the issue with -W error?
There was a problem hiding this comment.
MultiError is deprecated, and I didn't want to go for elaborate workarounds when I've got another PR ready to fix it (and re-enable -W error) so soon.
|
I updated the required checks so this can now be merged! codecov is indeed broken, we're sending empty reports: https://app.codecov.io/github/python-trio/pytest-trio/commit/f788fe7d1bc7e7cbfa8e86d482018afd785536d1. The uploader complains about the checkout, maybe that's the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended as a base for the actual feature work of #104 and #128; as a separate PR to make the next one much easier to review... and ensure that the tests all pass with just this base 😅
I also created python-trio/trio#2458 to track
async_generatorupstream.