Content-Length: 285167 | pFad | https://redirect.github.com/sveltejs/svelte/pull/15326

62 fix: `muted` reactive without `bind` and select/autofocus attributes … by paoloricciuti · Pull Request #15326 · sveltejs/svelte · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: muted reactive without bind and select/autofocus attributes … #15326

Merged
merged 2 commits into from
Feb 18, 2025
Merged

fix: muted reactive without bind and select/autofocus attributes … #15326

merged 2 commits into from
Feb 18, 2025
+85 −10

Conversation

paoloricciuti
Copy link
Member

Closes #15286
Closes #15316

Alternative to #15317

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@paoloricciuti @jhwz
fix: muted reactive without bind and select/autofocus attributes …
e26d8ff 
…working with function calls

Co-authored-by: Joel Howse <joel@helicalco.com>
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2025

🦋 Changeset detected

Latest commit: e26d8ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Preview: https://svelte-dev-git-preview-svelte-15326-svelte.vercel.app/

@github-actions GitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15326

@paoloricciuti paoloricciuti mentioned this pull request Feb 17, 2025
Closed
6 tasks
@jhwz
Copy link
Contributor

jhwz commented Feb 17, 2025

Nice, thanks for this! I was struggling to figure out how to memoize the expression.

@paoloricciuti paoloricciuti merged commit d8e78f7 into main Feb 18, 2025
10 checks passed
@paoloricciuti paoloricciuti deleted the muted-without-bind-select-autofocus-function-calls branch February 18, 2025 12:33
@github-actions github-actions bot mentioned this pull request Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReferenceError: $0 is not defined audio: muted property not updating without bind:muted
3 participants
@paoloricciuti @jhwz @trueadm








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://redirect.github.com/sveltejs/svelte/pull/15326

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy