-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: Fix docstring processing with Python 3.13+ #1594
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually, this fixes all the issues from #1585. The one ERROR left wasn't reported there. |
casperdcl
force-pushed
the
py313-docstring
branch
from
August 3, 2024 21:37
eafdd30
to
92dbbb8
Compare
casperdcl
added
p0-bug-critical ☢
Exception rasing
c1-quick 🕐
Complexity low
submodule ⊂
Periphery/subclasses
to-merge ↰
Imminent
labels
Aug 3, 2024
Fix docstring processing code to reindent the docstrings if using Python 3.13 or newer. Starting with this version, all docstrings are automatically dedented by Python, which causes the regular expression to fail to match. Fixes tqdm#1585
casperdcl
force-pushed
the
py313-docstring
branch
from
August 3, 2024 22:05
92dbbb8
to
43230f6
Compare
casperdcl
approved these changes
Aug 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sorry for the delay...
Released in v4.66.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c1-quick 🕐
Complexity low
p0-bug-critical ☢
Exception rasing
submodule ⊂
Periphery/subclasses
to-merge ↰
Imminent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix docstring processing code to reindent the docstrings if using Python 3.13 or newer. Starting with this version, all docstrings are automatically dedented by Python, which causes the regular expression to fail to match.
Fixes #1585