Content-Length: 320256 | pFad | https://redirect.github.com/tqdm/tqdm/issues/1594

9F cli: Fix docstring processing with Python 3.13+ by mgorny · Pull Request #1594 · tqdm/tqdm · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Fix docstring processing with Python 3.13+ #1594

Merged
merged 2 commits into from
Aug 3, 2024

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Jun 27, 2024

Fix docstring processing code to reindent the docstrings if using Python 3.13 or newer. Starting with this version, all docstrings are automatically dedented by Python, which causes the regular expression to fail to match.

Fixes #1585

@mgorny
Copy link
Contributor Author

mgorny commented Jun 27, 2024

Actually, this fixes all the issues from #1585. The one ERROR left wasn't reported there.

@hroncok
Copy link
Contributor

hroncok commented Jul 8, 2024

Actually, this fixes all the issues from #1585. The one ERROR left wasn't reported there.

I belive this handles the error: #1595

@casperdcl casperdcl changed the base branch from master to devel August 3, 2024 21:37
@casperdcl casperdcl added p0-bug-critical ☢ Exception rasing c1-quick 🕐 Complexity low submodule ⊂ Periphery/subclasses to-merge ↰ Imminent labels Aug 3, 2024
@casperdcl casperdcl changed the base branch from devel to master August 3, 2024 21:55
mgorny and others added 2 commits August 3, 2024 23:05
Fix docstring processing code to reindent the docstrings if using Python
3.13 or newer.  Starting with this version, all docstrings are
automatically dedented by Python, which causes the regular expression to
fail to match.

Fixes tqdm#1585
Copy link
Member

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the delay...

@casperdcl casperdcl merged commit 0254345 into tqdm:master Aug 3, 2024
16 checks passed
@casperdcl
Copy link
Member

Released in v4.66.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c1-quick 🕐 Complexity low p0-bug-critical ☢ Exception rasing submodule ⊂ Periphery/subclasses to-merge ↰ Imminent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failures with Python 3.13.0b1
3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://redirect.github.com/tqdm/tqdm/issues/1594

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy