Revert "Improve performance of hashRegExp lookup" #16803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
alexander-akait
approved these changes
Mar 10, 2023
|
@TheLarkInn Let's do small patch release |
|
Sounds great! Go ahead @alexander-akait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #16759
Discussion here: #16759 (comment)
Performance benchmarks showing the improvement were calculated on an M1 Macbook Pro, subsequent performance benchmarks performed on more powerful machines running an Intel architecture show a substantial regression from these changes. I'd suggest that we revert this feature and cut a patch release.