Improve PHP 8.5 compatibility - #3654
Merged
Merged
Conversation
This was
linked to
issues
Sep 1, 2025
Closed
bsweeney
force-pushed
the
php85-compatibility
branch
from
September 9, 2025 13:20
b347ac0 to
21054cb
Compare
Closed
bsweeney
force-pushed
the
php85-compatibility
branch
4 times, most recently
from
September 13, 2025 19:45
7dfc8c8 to
6eca577
Compare
- only use imagedestroy with PHP < 8 - only use xml_parser_free with PHP < 8 - only use curl_close with PHP < 8 - only use setAccessible reflection method with PHP < 8.1 - use http_get_last_response_headers with PHP >= 8.4 - utilize getimagesize support for SVG images - use canonical types for casts - improve array key null safety addresses #3644
bsweeney
force-pushed
the
php85-compatibility
branch
from
September 20, 2025 17:26
6eca577 to
7dc8ba4
Compare
|
Great job! I have locked all our active branches to Dompdf 3.1.1, and there are no longer any deprecation notices, for Php8.5, and everything continues to work for 8.5 and earlier Php releases. Let's hope for no more surprises. |
Member
Author
|
There appears to be an issue with the change to null handling in the font selection logic (#3660). I'll need to release an update soon. |
|
Just confirming that Dompdf 3.1.2 also works without any issues for us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #3644