Fix regression from 794ec85 - #3661
Merged
Merged
Conversation
There should be special handling of null here since otherwise the fallback font logic is never triggered And the fallback logic is using the $familyRaw as a caching key so setting it to 0 should solve both the 8.5 deprecation and keep the old functionality intact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There should be special handling of null here since otherwise the fallback font logic is never triggered
And the fallback logic is using the $familyRaw as a caching key so setting it to 0 should solve both the 8.5 deprecation and keep the old functionality intact