pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: https://github.com/python/cpython/pull/101633

" /> gh-101632: Add a RETURN_CONST instruction by penguin-wwy · Pull Request #101633 · python/cpython · GitHub
Skip to content

gh-101632: Add a RETURN_CONST instruction - #101633

Merged
iritkatriel merged 6 commits into
python:mainfrom
penguin-wwy:add_return_none
Feb 7, 2023
Merged

gh-101632: Add a RETURN_CONST instruction#101633
iritkatriel merged 6 commits into
python:mainfrom
penguin-wwy:add_return_none

Conversation

@penguin-wwy

@penguin-wwy penguin-wwy commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

@iritkatriel

Copy link
Copy Markdown
Member

Do you see a difference in any benchmarks?

@penguin-wwy

Copy link
Copy Markdown
Contributor Author

I am executing pyperformance, please wait :)

@penguin-wwy

Copy link
Copy Markdown
Contributor Author

@iritkatriel I update the pyperformance result in issue
#101632 (comment)

@arhadthedev arhadthedev added the performance Performance or resource usage label Feb 7, 2023
@iritkatriel

Copy link
Copy Markdown
Member

@iritkatriel I update the pyperformance result in issue
#101632 (comment)

Thanks, I'll try to replicate on our benchmark machine.

@iritkatriel

Copy link
Copy Markdown
Member

@iritkatriel I update the pyperformance result in issue
#101632 (comment)

Thanks, I'll try to replicate on our benchmark machine.

Also came out 1% faster.

Results are here.

@penguin-wwy

Copy link
Copy Markdown
Contributor Author

@iritkatriel I update the pyperformance result in issue
#101632 (comment)

Thanks, I'll try to replicate on our benchmark machine.

Also came out 1% faster.

Results are here.

Thanks. It turned out a little better than I expected.

@iritkatriel iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Feb 7, 2023
Comment thread Lib/test/test_code.py
@iritkatriel iritkatriel changed the title gh-101632: Add return const instruction gh-101632: Add a RETURN_CONST instruction Feb 7, 2023

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 7, 2023
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit afba682 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 7, 2023
@iritkatriel

Copy link
Copy Markdown
Member

The "s390x Fedora Refleaks PR" buildbot is broken (for a few months at least). All other test runs were successful.

@iritkatriel
iritkatriel merged commit 753fc8a into python:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.





Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy