gh-127604: ensure -ldl is passed only once to the linker - #133071
Merged
Conversation
picnixz
commented
Apr 28, 2025
vstinner
approved these changes
Apr 28, 2025
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM.
In the current main branch, make shows me many lines starting with gcc -ldl -ldl -ldl -ldl -ldl -ldl. Ooops :-)
With this change, I get gcc -ldl which seems better.
Contributor
|
This looks like it's addressed the 6x |
Member
Author
|
Ah... Why is life so hard. I'm no more on my dev session and I'll be busy this afternoon. Is it possible for someone to fix this as well? An alternate fix is to not pass I'm very sorry that I failed to fix the libffi part :( |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
faulthandler#127604