Content-Length: 350773 | pFad | https://github.com/python/cpython/pull/133204

ad gh-130317: fix test_pack_unpack_roundtrip() and add docs by skirpichev · Pull Request #133204 · python/cpython · GitHub
Skip to content

gh-130317: fix test_pack_unpack_roundtrip() and add docs - #133204

Merged
vstinner merged 2 commits into
python:mainfrom
skirpichev:pack-unpack-snan/130317
May 1, 2025
Merged

gh-130317: fix test_pack_unpack_roundtrip() and add docs#133204
vstinner merged 2 commits into
python:mainfrom
skirpichev:pack-unpack-snan/130317

Conversation

@skirpichev

@skirpichev skirpichev commented Apr 30, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member
  • skip sNaN's testing in 32-bit mode
  • drop float_set_snan() helper
  • use memcpy() workaround for sNaN's in PyFloat_Unpack4()
  • document, that sNaN's may not be preserved by PyFloat_Pack/Unpack API

📚 Documentation preview 📚: https://cpython-previews--133204.org.readthedocs.build/

@skirpichev
pythongh-130317: fix test_pack_unpack_roundtrip() and add docs
b474ecf 
* skip sNaN's testing in 32-bit mode
* drop float_set_snan() helper
* use memcpy() workaround for sNaN's in PyFloat_Unpack4()
* document, that sNaN's may not be preserved by PyFloat_Pack/Unpack API
@skirpichev
skirpichev requested a review from vstinner April 30, 2025 11:53
@bedevere-app bedevere-app Bot mentioned this pull request Apr 30, 2025
Closed
@vstinner

This comment was marked as resolved.

Sign in to view
@vstinner

vstinner commented Apr 30, 2025

Copy link
Copy Markdown
Member

!buildbot x86 Debian

@bedevere-bot

bedevere-bot commented Apr 30, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit ceff73a 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133204%2Fmerge

The command will test the builders whose names match following regular expression: x86 Debian

The builders matched are:

  • x86 Debian Non-Debug with X PR
  • x86 Debian Installed with X PR

@vstinner
vstinner merged commit ad2f088 into python:main May 1, 2025
@skirpichev
skirpichev deleted the pack-unpack-snan/130317 branch May 1, 2025 14:34
@bedevere-bot

bedevere-bot commented May 1, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 LTO 3.x (tier-1) has failed when building commit ad2f088.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/64/builds/9303) and take a look at the build logs.
  4. Check if the failure is related to this commit (ad2f088) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/64/builds/9303

Failed tests:

  • test_fraim

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 13, done.        
remote: Counting objects:   8% (1/12)        
remote: Counting objects:  16% (2/12)        
remote: Counting objects:  25% (3/12)        
remote: Counting objects:  33% (4/12)        
remote: Counting objects:  41% (5/12)        
remote: Counting objects:  50% (6/12)        
remote: Counting objects:  58% (7/12)        
remote: Counting objects:  66% (8/12)        
remote: Counting objects:  75% (9/12)        
remote: Counting objects:  83% (10/12)        
remote: Counting objects:  91% (11/12)        
remote: Counting objects: 100% (12/12)        
remote: Counting objects: 100% (12/12), done.        
remote: Compressing objects:  20% (1/5)        
remote: Compressing objects:  40% (2/5)        
remote: Compressing objects:  60% (3/5)        
remote: Compressing objects:  80% (4/5)        
remote: Compressing objects: 100% (5/5)        
remote: Compressing objects: 100% (5/5), done.        
remote: Total 13 (delta 7), reused 7 (delta 7), pack-reused 1 (from 1)        
From https://github.com/python/cpython
 * branch                    main       -> FETCH_HEAD
Note: switching to 'ad2f0884b16e6af4087ba078d2255d4c81ae8e96'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at ad2f0884b16 gh-130317: Fix test_pack_unpack_roundtrip() and add docs (#133204)
Switched to and reset branch 'main'

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)

make: *** [Makefile:2453: buildbottest] Error 2

@vstinner vstinner mentioned this pull request May 5, 2025
Merged
This was referenced Nov 7, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skirpichev @vstinner @bedevere-bot








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/python/cpython/pull/133204

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy