Skip to content

feat(devtools): update getSignalGraph #61541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

milomg
Copy link
Contributor

@milomg milomg commented May 20, 2025

add a function that we can inspect to jump to the source of a signal, and give every signal a unique id that devtools can use to match signals across calls to getSignalGraph

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

signals are now given a unique ID using a weakmap, and if they have a user function, we pass that through to the caller so they can call inspect(debuggableFn) to get chrome to jump to the source of the signal (see #61540 for usage)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from kirjs May 20, 2025 21:33
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: devtools labels May 20, 2025
@ngbot ngbot bot added this to the Backlog milestone May 20, 2025
@milomg milomg mentioned this pull request May 21, 2025
14 tasks
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Baside the suggestion, LGTM

@angular-robot angular-robot bot requested a review from JeanMeche May 21, 2025 20:53
add a function that we can inspect to jump to the source of a signal, and give every signal a unique id
that devtools can use to match signals across calls to getSignalGraph
@angular-robot angular-robot bot requested a review from JeanMeche May 22, 2025 02:53
@AleksanderBodurri AleksanderBodurri added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 22, 2025
@atscott atscott closed this in 396b543 May 22, 2025
@atscott
Copy link
Contributor

atscott commented May 22, 2025

This PR was merged into the repository by commit 396b543.

The changes were merged into the following branches: main

@milomg milomg deleted the signal-graph-3 branch May 22, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: devtools detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy