docs: update what is angular page #62276
Open
+3,029
−210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed adev-preview for 977d7f9 to: https://ng-dev-previews-fw--pr-angular-angular-62276-adev-prev-ro4p5zmv.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
| // We can assume that all illustrations are svg files | ||
| // We need to read svg content, instead of renering svg with `img`, | ||
| // cause we would like to use CSS variables to support dark and light mode. | ||
| let illustration = ''; |
There was a problem hiding this comment.
nit: these two would be cleaner as const ternaries
JeanMeche
reviewed
Jun 27, 2025
Comment on lines
19
to
+24
| } | ||
|
|
||
| :host.overview { | ||
| padding-top: 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
nit:
Suggested change
| } | |
| :host.overview { | |
| padding-top: 0; | |
| } | |
| &.overview { | |
| padding-top: 0; | |
| } | |
| } |
JeanMeche
reviewed
Jun 27, 2025
Comment on lines
+102
to
+103
| "ajv": "^8.17.1", | ||
| "ajv-draft-04": "^1.0.0", |
There was a problem hiding this comment.
Any reason for adding the deps ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
This PR does not contain customer logos or testimonials, which we can add at a later date.