Skip to content

feat: add tmux and gemini icons #19031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 29, 2025
Merged

feat: add tmux and gemini icons #19031

merged 5 commits into from
Jul 29, 2025
+4 −0

Conversation

35C4n0r
Copy link
Contributor

@35C4n0r 35C4n0r commented Jul 24, 2025 •
edited
Loading

Related PRs: #246 #229

@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Jul 24, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@35C4n0r
Copy link
Contributor Author

35C4n0r commented Jul 24, 2025

I have read the CLA Document and I hereby sign the CLA

cdrci2 added a commit to coder/cla that referenced this pull request Jul 24, 2025
@cdrci2
@35C4n0r has signed the CLA in coder/coder#19031
bbefcdf
@35C4n0r 35C4n0r mentioned this pull request Jul 24, 2025
Merged
8 tasks
matifali
matifali approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

Please also run make gen

@matifali
Copy link
Member

/cherry-pick release/2.24

@DevelopmentCats
Copy link
Contributor

@35C4n0r

Can you run make gen, and get these failing CI's resolved so we can merge this for the gemini and tmux icons?

@35C4n0r
Copy link
Contributor Author

35C4n0r commented Jul 29, 2025

@DevelopmentCats Is there any script to install all the dependencies ? I tried running make gen but it always fails due to some or other dependency issue.

@35C4n0r
Copy link
Contributor Author

35C4n0r commented Jul 29, 2025

@DevelopmentCats can you approve the ci tests

@35C4n0r
Copy link
Contributor Author

35C4n0r commented Jul 29, 2025

Error:

Determining the checkout info
/usr/bin/git branch --list --remote origin/feat-gemini-tmux-icon
/usr/bin/git tag --list feat-gemini-tmux-icon
Error: A branch or tag with the name 'feat-gemini-tmux-icon' could not be found

@matifali matifali merged commit 0ef7720 into coder:main Jul 29, 2025
23 of 24 checks passed
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 29, 2025
@35C4n0r @DevelopmentCats
feat: add tmux and gemini icons (#19031)
2445aa9 
Related PRs: #246 #229

---------

Co-authored-by: DevCats <christofer@coder.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

Assignees

@35C4n0r 35C4n0r

Labels
community Pull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@35C4n0r @matifali @DevelopmentCats
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy