Skip to content

fix(site): remove redundant alt text to prevent duplicated accessible names #19087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2025

Conversation

ssncferreira
Copy link
Contributor

Description

Removes the redundant alt text in the Combobox component to prevent screen readers from announcing duplicated names (e.g. "Rust Rust").

Changes

  • Remove redundant alt text from Combobox ExternalImage
  • Update Combobox tests accordingly

Related to: #19063 (comment)

@ssncferreira ssncferreira marked this pull request as ready for review July 29, 2025 18:14
@ssncferreira ssncferreira requested a review from Parkreiner July 29, 2025 18:14
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing this 🙏

Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@ssncferreira ssncferreira merged commit 44d9356 into main Jul 30, 2025
34 checks passed
@ssncferreira ssncferreira deleted the ssncferreira/fix-site-combobox-alt-text branch July 30, 2025 08:54
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy