No naked booleans

code-asher · code-asher · commit 9f591ac2f2f5 · 2024-09-12T13:09:50.000-08:00
diff --git a/src/main/kotlin/com/coder/gateway/CoderRemoteProvider.kt b/src/main/kotlin/com/coder/gateway/CoderRemoteProvider.kt
@@ -161,7 +161,7 @@ class CoderRemoteProvider(
      * List of actions that appear next to the account.
      */
     override fun getAdditionalPluginActions(): List<RunnableActionDescription> = listOf(
-        Action("Settings", false) {
+        Action("Settings", closesPage = false) {
             ui.showUiPage(settingsPage)
         },
     )
diff --git a/src/main/kotlin/com/coder/gateway/views/CoderSettingsPage.kt b/src/main/kotlin/com/coder/gateway/views/CoderSettingsPage.kt
@@ -47,7 +47,7 @@ class CoderSettingsPage(private val settings: CoderSettingsService) : CoderPage(
     override fun getTitle(): String = "Coder Settings"
 
     override fun getActionButtons(): MutableList<RunnableActionDescription> = mutableListOf(
-        Action("Save", true) {
+        Action("Save", closesPage = true) {
             settings.binarySource = get(binarySourceField) as String
             settings.binaryDirectory = get(binaryDirectoryField) as String
             settings.dataDirectory = get(dataDirectoryField) as String
diff --git a/src/main/kotlin/com/coder/gateway/views/ConnectPage.kt b/src/main/kotlin/com/coder/gateway/views/ConnectPage.kt
@@ -54,8 +54,8 @@ class ConnectPage(
      * Show a retry button on error.
      */
     override fun getActionButtons(): MutableList<RunnableActionDescription> = listOfNotNull(
-        if (errorField != null) Action("Retry", false) { retry() } else null,
-        if (errorField != null) Action("Cancel", false) { onCancel() } else null,
+        if (errorField != null) Action("Retry", closesPage = false) { retry() } else null,
+        if (errorField != null) Action("Cancel", closesPage = false) { onCancel() } else null,
     ).toMutableList()
 
     /**
diff --git a/src/main/kotlin/com/coder/gateway/views/SignInPage.kt b/src/main/kotlin/com/coder/gateway/views/SignInPage.kt
@@ -38,7 +38,7 @@ class SignInPage(
      * Buttons displayed at the bottom of the page.
      */
     override fun getActionButtons(): MutableList<RunnableActionDescription> = mutableListOf(
-        Action("Sign In", false) { submit() },
+        Action("Sign In", closesPage = false) { submit() },
     )
 
     /**
diff --git a/src/main/kotlin/com/coder/gateway/views/TokenPage.kt b/src/main/kotlin/com/coder/gateway/views/TokenPage.kt
@@ -46,7 +46,7 @@ class TokenPage(
      * Buttons displayed at the bottom of the page.
      */
     override fun getActionButtons(): MutableList<RunnableActionDescription> = mutableListOf(
-        Action("Connect", false) { submit(get(tokenField) as String) },
+        Action("Connect", closesPage = false) { submit(get(tokenField) as String) },
     )
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ class CoderRemoteProvider(`
`161`	`161`	`* List of actions that appear next to the account.`
`162`	`162`	`*/`
`163`	`163`	`override fun getAdditionalPluginActions(): List<RunnableActionDescription> = listOf(`
`164`		`- Action("Settings", false) {`
	`164`	`+ Action("Settings", closesPage = false) {`
`165`	`165`	`ui.showUiPage(settingsPage)`
`166`	`166`	`},`
`167`	`167`	`)`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ class SignInPage(`
`38`	`38`	`* Buttons displayed at the bottom of the page.`
`39`	`39`	`*/`
`40`	`40`	`override fun getActionButtons(): MutableList<RunnableActionDescription> = mutableListOf(`
`41`		`- Action("Sign In", false) { submit() },`
	`41`	`+ Action("Sign In", closesPage = false) { submit() },`
`42`	`42`	`)`
`43`	`43`
`44`	`44`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ class TokenPage(`
`46`	`46`	`* Buttons displayed at the bottom of the page.`
`47`	`47`	`*/`
`48`	`48`	`override fun getActionButtons(): MutableList<RunnableActionDescription> = mutableListOf(`
`49`		`- Action("Connect", false) { submit(get(tokenField) as String) },`
	`49`	`+ Action("Connect", closesPage = false) { submit(get(tokenField) as String) },`
`50`	`50`	`)`
`51`	`51`
`52`	`52`	`/**`