Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

Handling Multiple TargetFrameworks through BuildProperties #567

Merged
merged 44 commits into from
Oct 24, 2020
Merged

Handling Multiple TargetFrameworks through BuildProperties #567

Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
8dbb2a5
adding a sample project with plural form of TargetFrameworks for debu…
tebeco Jun 26, 2020
333e9cf
add --framework argument to RunCommand
tebeco Jun 27, 2020
d4cecb9
Pass down "framework" as a BuildProperty if not already defined in th…
tebeco Jun 27, 2020
2574622
Do no throw anymore when multiple TargetFrameworks are found, if one …
tebeco Jun 27, 2020
b0ff307
replicating Signature change on code base (that does not look like a …
tebeco Jun 27, 2020
48f42c6
adding comment to be explicit on what this does
tebeco Jun 27, 2020
889c15d
Check that the specified BuildProperties["TargetFramework"] is on of …
tebeco Jun 27, 2020
6ccf418
add launchSettings for debug
tebeco Jul 12, 2020
e5b00f5
Create a BuildCommandArguments for the BuildCommand / add a "framewor…
tebeco Jul 12, 2020
96ba02d
add "-f {framework}" to dotnet publish if a TargetFramework BuildProp…
tebeco Jul 12, 2020
a71d7b2
Create a GenerateCommandArguments for the GenerateCommand / add a "fr…
tebeco Jul 12, 2020
f6d6ad2
Create a PushCommandArguments for the PushCommand / add a "framework"…
tebeco Jul 12, 2020
7a370c1
Create a UndeployCommandArguments for the UndeployCommand / add a "fr…
tebeco Jul 12, 2020
365c95d
Create a DeployCommandArguments for the DeployCommand / add a "framew…
tebeco Jul 12, 2020
67c2eaa
framework is now an optional parameter defaulted to null
tebeco Jul 13, 2020
77f04bb
Change sample to use LTS only
tebeco Jul 13, 2020
29bf9b7
Make "framework" argument nullable / optional / defaulted to null
tebeco Jul 13, 2020
e4c0ba6
remove "Force" from "PushCommand" and "PushCommandArguments" if it's …
tebeco Jul 13, 2020
3d7ff54
re-use the equivalent message than "dotnet run" on a project with mul…
tebeco Jul 13, 2020
2fac5cd
Create a StandardOptions for Framework
tebeco Jul 13, 2020
1538fb7
Remove unused StandardOption.Force and add StandardOption.CreateForce…
tebeco Jul 14, 2020
1e5b2d7
Use StandardOptions.Framework in various commands
tebeco Jul 14, 2020
a082ff7
use StandardOptions.Force ni various commands
tebeco Jul 14, 2020
2d197c9
Create a new InitCommandArguments and re-use the same OutputContext l…
tebeco Jul 14, 2020
edaa741
prefer type alias (String.IsNullOrEmpty => string.IsNullOrEmpty), not…
tebeco Jul 14, 2020
e9f17b1
Adding assets for E2E about multi-targetframeworks that returns the c…
tebeco Jul 18, 2020
e81d15b
Adding test for "tye run" with either buildProperties in the yaml or …
tebeco Jul 18, 2020
9a9e9aa
Add test and testasset project for both TargetFrameworks and TargetFr…
tebeco Jul 18, 2020
f91deeb
Always overwrite the TargetFramework if one is specified from the CLI…
tebeco Jul 19, 2020
a8e6c8a
Test the ability to override TargetFramework from CLI even if define …
tebeco Jul 19, 2020
25f649b
Consistency over ApplicationFactory.CreateAsync in all E2E tests
tebeco Jul 19, 2020
18e1ec8
rename testasset project to multi-targetframeworks to match generated…
tebeco Jul 19, 2020
6efc117
Add E2E for tye build when project uses multi-targetframeworks
tebeco Jul 19, 2020
b1d4977
Adding test directly for ApplicationFactory to check that it override…
tebeco Jul 21, 2020
aceeba0
Adding test to make sure it still throw if there's no explicit Target…
tebeco Jul 21, 2020
d5a45e6
Adding test for ApplicationFactory.CreateAsync with a framework if no…
tebeco Jul 21, 2020
0773d99
make cli arguments class private
tebeco Sep 2, 2020
1761cfe
review: remove extra line
tebeco Sep 2, 2020
02f2565
review: remove 'framework' notion from Undeploy
tebeco Sep 15, 2020
56ab74e
Fix project evaluation of multi-targetd projects
Oct 21, 2020
031b646
Merge pull request #1 from dotnet/johluo/multi-tfm-fixup
tebeco Oct 21, 2020
1fff983
Fixup a few more tests
Oct 21, 2020
e632b84
Comment updates
Oct 22, 2020
e806436
Ensure TFM is only applied for multi-targeting projects
Oct 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change sample to use LTS only
  • Loading branch information
@tebeco
tebeco committed Sep 30, 2020
commit 77f04bbbba867cd372447e17c917d6cdc14275b3
2 changes: 1 addition & 1 deletion samples/app-with-targetframeworks/MultipleTargetFrameworks/MultipleTargetFrameworks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Web">

<PropertyGroup>
<TargetFrameworks>netcoreapp3.1;netcoreapp2.2</TargetFrameworks>
<TargetFrameworks>netcoreapp3.1;netcoreapp2.1</TargetFrameworks>
</PropertyGroup>

<ItemGroup Condition="'$(TargetFramework)' != 'netcoreapp3.1'">
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy