Skip to content

Add code coverage for DataGridVieLinkCell #13524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add code coverage for DataGridVieLinkCell #13524

wants to merge 3 commits into from

Conversation

Zheng-Li01
Copy link
Member

Related #13442

Proposed changes

Add unit test file: DataGridVieLinkCellTests.cs for DataGridVieLinkCell.cs file.

@Zheng-Li01 Zheng-Li01 requested a review from a team as a code owner May 26, 2025 08:10
@codecov Codecov
Copy link

codecov bot commented May 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.10913% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.65471%. Comparing base (5821493) to head (a488559).
Report is 24 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                  @@
##                main      #13524          +/-   ##
====================================================
+ Coverage   62.21083%   76.65471%   +14.44387%     
====================================================
  Files           3213        3231          +18     
  Lines         638302      639598        +1296     
  Branches       47201       47327         +126     
====================================================
+ Hits          397093      490282       +93189     
+ Misses        234153      145728       -88425     
+ Partials        7056        3588        -3468
Flag Coverage Δ
Debug 76.65471% <99.10913%> (+14.44387%) ⬆️
integration 18.79376% <ø> (+0.00497%) ⬆️
production 51.09424% <ø> (+32.30545%) ⬆️
test 97.40628% <99.10913%> (+0.00216%) ⬆️
unit 48.49298% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Zheng-Li01 Zheng-Li01 added waiting-review This item is waiting on review by one or more members of team area-test coverage labels May 26, 2025
@LeafShi1 LeafShi1 requested a review from ricardobossan May 27, 2025 07:55
@ricardobossan ricardobossan mentioned this pull request May 26, 2025
Open
48 tasks
@ricardobossan ricardobossan requested a review from Copilot May 27, 2025 21:42
Copilot
Copilot AI reviewed May 27, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new unit test file to improve code coverage for the DataGridViewLinkCell class.

  • Introduces tests for default properties and property round-tripping behavior.
  • Validates cloning behavior and special cases for derived types.
Comments suppressed due to low confidence (2)

src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewLinkCellTests.cs:50

  • Consider asserting that the expected invalidation side effect (e.g., a call to InvalidateCell) actually occurs when ActiveLinkColor changes, rather than just verifying the property value.
public void ActiveLinkColor_Set_TriggersInvalidateCell_WhenInDataGridViewAndRowIndexSet()

src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewLinkCellTests.cs:117

  • Consider verifying that the cell invalidation is triggered when LinkBehavior is set, for example by using a test double or hook, instead of solely checking the property value.
public void LinkBehavior_Set_TriggersInvalidateCell_WhenInDataGridViewAndRowIndexSet()

ricardobossan
ricardobossan requested changes May 27, 2025
View reviewed changes
@dotnet-policy-service dotnet-policy-service bot added the waiting-author-feedback The team requires more information from the author label May 27, 2025
ricardobossan
ricardobossan reviewed May 27, 2025
View reviewed changes
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding tests for protected methods of the system under test.

@Zheng-Li01
1. Address the FeedBacks
22798d3 
2. Add test cases for Protected method/properties
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label May 30, 2025
@ricardobossan ricardobossan added the waiting-author-feedback The team requires more information from the author label May 30, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jun 3, 2025
ricardobossan
ricardobossan approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Epica3055 Epica3055 Epica3055 left review comments

Copilot code review Copilot Copilot left review comments

@ricardobossan ricardobossan ricardobossan approved these changes

Assignees

@Zheng-Li01 Zheng-Li01

Labels
area-test coverage waiting-review This item is waiting on review by one or more members of team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zheng-Li01 @ricardobossan @Epica3055
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy