Skip to content

No ndim for iw #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

No ndim for iw #801

wants to merge 6 commits into from

Conversation

FlynnOConnell
Copy link
Collaborator

Dont think we need ndim for image widgets. Was just using some suite2p binary files that didn't pass _is_array_like() because it didn't have ndim. Will test if you dont think its stupid

Copy link

github-actions bot commented Apr 16, 2025

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/no-ndim-for-iw

@FlynnOConnell
Copy link
Collaborator Author

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/no-ndim-for-iw

stealing this

@kushalkolar
Copy link
Member

I think this would also have to be changed in __init__ ??

@FlynnOConnell
Copy link
Collaborator Author

I think this would also have to be changed in __init__ ??

@kushalkolar Sorry I completely missed this comment! The changes I made are in init, can you elaborate?

@kushalkolar
Copy link
Member

I think this would also have to be changed in __init__ ??

@kushalkolar Sorry I completely missed this comment! The changes I made are in init, can you elaborate?

It's in set_data()?

@FlynnOConnell
Copy link
Collaborator Author

@kushalkolar fixed this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy