feat(nextjs): Disable server webpack-handling for static builds #15751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chargome
reviewed
Mar 24, 2025
| // Symbolication for dev-mode errors is done elsewhere. | ||
| if (!isDev) { | ||
| if (!isDev || !(isStaticExport && isServer)) { |
There was a problem hiding this comment.
Suggested change
| if (!isDev || !(isStaticExport && isServer)) { | |
| if (!isDev && !(isStaticExport && isServer)) { |
Only handle webpack when we're in prod AND we don't have a output: 'export' build
There was a problem hiding this comment.
I changed it to !(isDev || (isStaticExport && isServer)) as it's easier to wrap the head around it (it contains two sides connected with OR and then everything is negated).
However, it's the same logical expression as !isDev && !(isStaticExport && isServer).
lforst
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When static builds are enabled, Sentry should not change webpack configuration for the server/edge runtime as there is no server.
closes #12420