feat(browser): Add logger.X methods to browser SDK #15763
Merged
+431
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
size-limit report 📦
|
chargome
approved these changes
Mar 21, 2025
Comment on lines
+39
to
+50
| if (WINDOW.document) { | ||
| WINDOW.document.addEventListener('visibilitychange', () => { | ||
| if (WINDOW.document.visibilityState === 'hidden') { | ||
| _INTERNAL_flushLogsBuffer(client); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| client.on('flush', () => { | ||
| _INTERNAL_flushLogsBuffer(client); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Could we not also just flush in the client callback?
There was a problem hiding this comment.
Which client callback are you referring too?
There was a problem hiding this comment.
client.on('flush', () => {
_INTERNAL_flushLogsBuffer(client);
});
AbhiPrasad
added a commit
that referenced
this pull request
Mar 24, 2025
ref #15526 Continuing off the work from #15763, this PR adds the logging public API to the Node SDK. It also adds a basic weight-based flushing strategy to the SDK that is in the server-runtime client. The main file added was `log.ts`. In that file I've added logger methods for `trace`, `debug`, `info`, `warn`, `error`, `fatal` (the log severity levels) as well as an internal capture log helper all these methods call. Usage: ```js import * as Sentry from "@sentry/node"; Sentry.init({ dsn: "your-dsn-here", _experiments: { enableLogs: true // This is required to use the logging features } }); // Trace level (lowest severity) Sentry.logger.trace("This is a trace message", { userId: 123 }); // Debug level Sentry.logger.debug("This is a debug message", { component: "UserProfile" }); // Info level Sentry.logger.info("User %s logged in successfully", [123]); // Warning level Sentry.logger.warn("API response was slow", { responseTime: 2500 }); // Error level Sentry.logger.error("Failed to load user %s data", [123], { errorCode: 404 }); // Critical level Sentry.logger.critical("Database connection failed", { dbHost: "primary-db" }); // Fatal level (highest severity) Sentry.logger.fatal("Application is shutting down unexpectedly", { memory: "exhausted" }); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #15526
Continuing off the work from #15717, this PR adds the logging public API to the Browser SDK. It also adds a basic flushing strategy to the SDK that is timeout based. This is done to help save bundle size.
The main file added was
log.ts. This has three areas to look at:trace,debug,info,warn,error,fatal(the log severity levels) as well as an internal capture log helper all these methods call.addFlushingListenerswhich adds listeners to flush the logs buffer on client flush and document visibility hidden.I also removed any logs logic from the
BrowserClient, which should ensure this stays as bundle size efficient as possible.Usage: