feat(core): Allow to specify depth to dropUndefinedKeys
#15783
+157
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
reviewed
Mar 21, 2025
| origin: attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined, | ||
| links: convertSpanLinksForEnvelope(links), | ||
| }); | ||
| return dropUndefinedKeys( |
There was a problem hiding this comment.
Do we even need to call dropUndefinedKeys here?
There was a problem hiding this comment.
I extracted this out here: #15792 - I think you are right 🤔
9e7b55d to
f9e2f48
Compare
|
Actually, after some more thought - maybe we can completely remove this and just rewrite the few places we actually need this 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today,
dropUndefinedKeys()will iterate through all objects and arrays and make sure to drop undefined keys everywhere.In reality, we do not need this behavior in most/many cases - often, just removing undefined values one level deep should be more than good enough (apart from cases like #15781 where we maybe do not need it at all!)
So this PR introduces an optional second argument to
dropUndefinedKeys()which is a depth, which defaults toInfinity. It will drop undefined keys recursively until it reaches this depth.By specifying e.g.
1there, only the top level of the passed in object will be checked for undefined values.