QL4QL: Discard predicates are always alive #20013
Merged
+26
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8533643 to
1723c6e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for discard predicates in the dead code analysis for QL4QL. Discard predicates, annotated with overlay[discard_entity], are now recognized as always alive and excluded from dead code detection.
- Adds AST support for recognizing
overlay[discard_entity]annotations - Updates the dead code analysis to treat discard predicates as alive
- Includes test coverage for the new functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ql/ql/src/codeql_ql/ast/Ast.qll | Adds AST support for parsing overlay[discard_entity] annotations |
| ql/ql/src/codeql_ql/style/DeadCodeQuery.qll | Updates dead code analysis to treat discard predicates as alive |
| ql/ql/test/queries/style/DeadCode/Foo.qll | Adds test case for discard predicate functionality |
hvitved
previously approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private discard entity predicates are currently marked as dead code by the QL4QL dead code query. This PR updates the query such that discard predicates are always considered alive.