refactor: split get type annotation if statement

HenryBrown0 · HenryBrown0 · commit 0f45d976eb6f · 2023-09-06T20:01:52.000+01:00
diff --git a/lib/rules/boolean-prop-naming.js b/lib/rules/boolean-prop-naming.js
@@ -240,27 +240,25 @@ module.exports = {
       }
 
       if (
-        component.node.parent
-        && component.node.parent.type === 'VariableDeclarator'
-        && component.node.parent.id
-        && component.node.parent.id.type === 'Identifier'
-        && component.node.parent.id.typeAnnotation
-        && component.node.parent.id.typeAnnotation.typeAnnotation
-        && (
-          (component.node.parent.id.typeAnnotation.typeAnnotation.typeArguments
-          && (
-            component.node.parent.id.typeAnnotation.typeAnnotation.typeArguments.type === 'TSTypeParameterInstantiation'
-            || component.node.parent.id.typeAnnotation.typeAnnotation.typeArguments.type === 'TypeParameterInstantiation'
-          ))
-        || (component.node.parent.id.typeAnnotation.typeAnnotation.typeParameters
-          && (component.node.parent.id.typeAnnotation.typeAnnotation.typeParameters.type === 'TSTypeParameterInstantiation'
-          || component.node.parent.id.typeAnnotation.typeAnnotation.typeParameters.type === 'TypeParameterInstantiation'
-          ))
-        )
+        !component.node.parent
+        || component.node.parent.type !== 'VariableDeclarator'
+        || !component.node.parent.id
+        || component.node.parent.id.type !== 'Identifier'
+        || !component.node.parent.id.typeAnnotation
+        || !component.node.parent.id.typeAnnotation.typeAnnotation
       ) {
-        return component.node.parent.id.typeAnnotation.typeAnnotation.typeParameters.params.find(
-          (param) => param.type === 'TSTypeReference' || param.type === 'GenericTypeAnnotation'
-        );
+        return;
+      }
+
+      const annotationArgs = component.node.parent.id.typeAnnotation.typeAnnotation.typeArguments
+        || component.node.parent.id.typeAnnotation.typeAnnotation.typeParameters;
+      if (
+        annotationArgs
+        && (annotationArgs.type === 'TSTypeParameterInstantiation' || annotationArgs.type === 'TypeParameterInstantiation')
+      ) {
+        return annotationArgs.params.find((param) => (
+          param.type === 'TSTypeReference' || param.type === 'GenericTypeAnnotation'
+        ));
       }
     }
 
