- Requested Changes

kamal-qureshi · kamal-qureshi · commit b454a7ff53ff · 2025-06-16T14:36:09.000+05:00
diff --git a/client/packages/lowcoder/src/comps/comps/avatar.tsx b/client/packages/lowcoder/src/comps/comps/avatar.tsx
@@ -186,7 +186,7 @@ const AvatarView = (props: RecordConstructorToView<typeof childrenMap>) => {
             shape={shape}
             $style={props.avatarStyle}
             src={src.value}
-            onClick={() => handleClickEvent()}
+            onClick={handleClickEvent}
           >
             {title.value}
           </AvatarWrapper>
diff --git a/client/packages/lowcoder/src/comps/comps/commentComp/commentComp.tsx b/client/packages/lowcoder/src/comps/comps/commentComp/commentComp.tsx
@@ -179,7 +179,7 @@ const CommentCompBase = (
   const generateCommentAvatar = (item: commentDataTYPE) => {
     return (
       <Avatar
-        onClick={() => handleClickEvent()}
+        onClick={handleClickEvent}
         // If there is an avatar, no background colour is set, and if displayName is not null, displayName is called using getInitialsAndColorCode
         style={{
           backgroundColor: item?.user?.avatar
@@ -296,7 +296,7 @@ const CommentCompBase = (
                   avatar={generateCommentAvatar(item)}
                   title={
                     <div 
-                      onClick={() => handleClickEvent()}
+                      onClick={handleClickEvent}
                     >
                       <a>{item?.user?.name}</a>
                       <Tooltip
diff --git a/client/packages/lowcoder/src/comps/comps/containerComp/cardComp.tsx b/client/packages/lowcoder/src/comps/comps/containerComp/cardComp.tsx
@@ -239,7 +239,7 @@ export const ContainerBaseComp = (function () {
         $cardType={props.cardType}
         onMouseEnter={() => props.onEvent('focus')}
         onMouseLeave={() => props.onEvent('blur')}
-        onClick={() => handleClickEvent()}
+        onClick={handleClickEvent}
       >
         <Card
           style={{ width: width, height: '100%' }}
diff --git a/client/packages/lowcoder/src/comps/comps/iconComp.tsx b/client/packages/lowcoder/src/comps/comps/iconComp.tsx
@@ -137,7 +137,7 @@ const IconView = (props: RecordConstructorToView<typeof childrenMap>) => {
       $sourceMode={props.sourceMode}
       $animationStyle={props.animationStyle}
       style={style}
-      onClick={() => handleClickEvent()}
+      onClick={handleClickEvent}
     >
       { props.sourceMode === 'standard'
         ? (props.icon || '')
diff --git a/client/packages/lowcoder/src/comps/comps/imageComp.tsx b/client/packages/lowcoder/src/comps/comps/imageComp.tsx
@@ -215,7 +215,7 @@ const ContainerImg = (props: RecordConstructorToView<typeof childrenMap>) => {
           draggable={false}
           preview={props.supportPreview ? {src: props.previewSrc || props.src.value } : false}
           fallback={DEFAULT_IMG_URL}
-          onClick={() => handleClickEvent()}
+          onClick={handleClickEvent}
         />
       </div>
     </Container>
diff --git a/client/packages/lowcoder/src/comps/comps/tableComp/column/columnTypeComps/columnAvatarsComp.tsx b/client/packages/lowcoder/src/comps/comps/tableComp/column/columnTypeComps/columnAvatarsComp.tsx
@@ -120,7 +120,7 @@ const MemoizedAvatar = React.memo(({
     
     // Then trigger main component event
     handleClickEvent()
-  }, [onEvent, onItemEvent]);
+  }, [onItemEvent, handleClickEvent]);
 
   return (
     <Tooltip title={item.Tooltip} key={index}>
diff --git a/client/packages/lowcoder/src/comps/comps/tableComp/column/columnTypeComps/columnDropdownComp.tsx b/client/packages/lowcoder/src/comps/comps/tableComp/column/columnTypeComps/columnDropdownComp.tsx
@@ -62,7 +62,7 @@ const DropdownMenu = React.memo(({ items, options, onEvent }: { items: any[]; op
     item && options[itemIndex]?.onEvent("click");
     // Also trigger the dropdown's main event handler
     handleClickEvent();
-  }, [items, options, onEvent]);
+  }, [items, options, handleClickEvent]);
 
   const handleMouseDown = useCallback((e: React.MouseEvent) => {
     e.stopPropagation();
diff --git a/client/packages/lowcoder/src/comps/comps/tableComp/column/columnTypeComps/columnSelectComp.tsx b/client/packages/lowcoder/src/comps/comps/tableComp/column/columnTypeComps/columnSelectComp.tsx
@@ -6,7 +6,6 @@ import { IconControl } from "comps/controls/iconControl";
 import { MultiCompBuilder } from "comps/generators";
 import { optionsControl } from "comps/controls/optionsControl";
 import { disabledPropertyView, hiddenPropertyView } from "comps/utils/propertyUtils";
-
 import { trans } from "i18n";
 import { ColumnTypeCompBuilder, ColumnTypeViewFn } from "../columnTypeCompBuilder";
 import { ColumnValueTooltip } from "../simpleColumnTypeComps";
@@ -146,14 +145,11 @@ const SelectEdit = React.memo((props: SelectEditProps) => {
     if (!mountedRef.current) return;
     props.onChange(val);
     setCurrentValue(val);
+    
     // Trigger the specific option's event handler
     const selectedOption = props.options.find(option => option.value === val);
     if (selectedOption?.onEvent) {
-      if (selectedOption.onEvent.isBind("click")) {
-        selectedOption.onEvent("click");
-      } else if (selectedOption.onEvent.isBind("doubleClick")) {
-        selectedOption.onEvent("doubleClick");
-      }
+      selectedOption.onEvent("click");
     }
     
     // Also trigger the main component's event handler
diff --git a/client/packages/lowcoder/src/comps/comps/tableComp/column/columnTypeComps/simpleTextComp.tsx b/client/packages/lowcoder/src/comps/comps/tableComp/column/columnTypeComps/simpleTextComp.tsx
@@ -54,7 +54,7 @@ const SimpleTextContent = React.memo(({ value, prefixIcon, suffixIcon, onEvent }
   
   const handleClick = useCallback(() => {
      handleClickEvent()
-  }, [onEvent]);
+  }, [handleClickEvent]);
 
   return (
     <TextWrapper onClick={handleClick}>
diff --git a/client/packages/lowcoder/src/comps/comps/textComp.tsx b/client/packages/lowcoder/src/comps/comps/textComp.tsx
@@ -229,7 +229,7 @@ const TextView = React.memo((props: ToViewReturn<ChildrenType>) => {
 
   const handleClick = React.useCallback(() => {
     handleClickEvent()
-  }, [props.onEvent]);
+  }, [handleClickEvent]);
 
   const containerStyle = useMemo(() => ({
     justifyContent: props.horizontalAlignment,

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ const AvatarView = (props: RecordConstructorToView<typeof childrenMap>) => {`
`186`	`186`	`shape={shape}`
`187`	`187`	`$style={props.avatarStyle}`
`188`	`188`	`src={src.value}`
`189`		`- onClick={() => handleClickEvent()}`
	`189`	`+ onClick={handleClickEvent}`
`190`	`190`	`>`
`191`	`191`	`{title.value}`
`192`	`192`	`</AvatarWrapper>`
Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ export const ContainerBaseComp = (function () {`
`239`	`239`	`$cardType={props.cardType}`
`240`	`240`	`onMouseEnter={() => props.onEvent('focus')}`
`241`	`241`	`onMouseLeave={() => props.onEvent('blur')}`
`242`		`- onClick={() => handleClickEvent()}`
	`242`	`+ onClick={handleClickEvent}`
`243`	`243`	`>`
`244`	`244`	`<Card`
`245`	`245`	`style={{ width: width, height: '100%' }}`
Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ const IconView = (props: RecordConstructorToView<typeof childrenMap>) => {`
`137`	`137`	`$sourceMode={props.sourceMode}`
`138`	`138`	`$animationStyle={props.animationStyle}`
`139`	`139`	`style={style}`
`140`		`- onClick={() => handleClickEvent()}`
	`140`	`+ onClick={handleClickEvent}`
`141`	`141`	`>`
`142`	`142`	`{ props.sourceMode === 'standard'`
`143`	`143`	`? (props.icon \|\| '')`