Skip to content

fix(#668): appendChild is called thought there is no need to call it except for root component #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

srghma
Copy link
Contributor

@srghma srghma commented Jun 10, 2020

2020-06-10-13:53:04-screenshot
2020-06-10-13:53:09-screenshot

@thomashoneyman
Copy link
Member

@srghma I’m happy to review this and I would love to merge if we can get a nice performance improvement! Do you mind saving any larger refactoring for another time and focusing just on the changes relevant to this PR here? Otherwise it becomes difficult as a reviewer to see what exactly has changed. For example, moving modules removes the ability to see the diff side by side.

@srghma
Copy link
Contributor Author

srghma commented Jun 10, 2020

@thomashoneyman oops, I unintentionally added extra commit, fixed

@thomashoneyman
Copy link
Member

@natefaubion @garyb I'm not familiar with this part of the code; do either of you have time for feedback wrt this change? If not, I can also take a little time to familiarize myself and then provide a review.

@srghma
Copy link
Contributor Author

srghma commented Jun 17, 2020

@thomashoneyman tnx for pushing it

NB: as an alternative approach we can split the render function from spec on renderChildComponent and renderRootComponent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy