Skip to content

gh-136442: Fix unittest to return exit code 5 when setUpClass raises an exception #136487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ueshin
Copy link

@ueshin ueshin commented Jul 9, 2025

Fixes unittest to return exit code 5 when setUpClass raises an exception.

import unittest

class BugTest(unittest.TestCase):
    @classmethod
    def setUpClass(cls):
        raise ValueError("Simulated setup failure")

    def test_example(self):
        self.assertTrue(True)
  • before
$ ./python.exe -m unittest bug_test.py
E
======================================================================
ERROR: setUpClass (bug_test.BugTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/.../cpython/bug_test.py", line 6, in setUpClass
    raise ValueError("Simulated setup failure")
ValueError: Simulated setup failure

----------------------------------------------------------------------
Ran 0 tests in 0.000s

FAILED (errors=1)
$ echo $?
5
  • after
$ ./python.exe -m unittest bug_test.py
E
======================================================================
ERROR: setUpClass (bug_test.BugTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/.../cpython/bug_test.py", line 6, in setUpClass
    raise ValueError("Simulated setup failure")
ValueError: Simulated setup failure

----------------------------------------------------------------------
Ran 0 tests in 0.000s

FAILED (errors=1)
$ echo $?
1

@python-cla-bot
Copy link

python-cla-bot bot commented Jul 9, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Jul 9, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy