gh-136492: Add FrameLocalsProxyType to types
#136546
Conversation
|
Ugh, those test failures look like an existing bug on |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@python/organization-owners Could you block blockchainGuru1018 for spam & misguided reviews? TiA. |
Could you be more specific? Maybe raise an issue for that so I can fix it later? |
There were a few things I had to skip in |
|
Okay now we need some typing expert to review this. @JelleZijlstra maybe? |
|
I'd also appreciate it if @AA-Turner could take a look; he's done some recent work with |
|
You don't really need a static typing expert for the |
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Misc/NEWS.d/next/Library/2025-07-11-10-23-44.gh-issue-136492.BVi5h0.rst
Outdated
Show resolved
Hide resolved
Lib/test/test_types.py
Outdated
| @@ -58,6 +58,7 @@ def test_names(self): | |||
| 'MethodDescriptorType', 'MethodType', 'MethodWrapperType', | |||
| 'ModuleType', 'NoneType', 'NotImplementedType', 'SimpleNamespace', | |||
| 'TracebackType', 'UnionType', 'WrapperDescriptorType', | |||
| 'FrameLocalsProxyType' | |||
There was a problem hiding this comment.
Please keep the list sorted (GH doesn't let me add a suggestion)
There was a problem hiding this comment.
I had that originally but @picnixz had reservations about it.
There was a problem hiding this comment.
I think it's better to keep the list sorted rather than attempt to minimise 3-4 lines of diff here.
There was a problem hiding this comment.
My suggestion was to keep it sorted but by just adding the export on its own line.
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
FrameLocalsProxy to typesFrameLocalsProxyType to types
This reverts commit 58e8577.
This reverts commit 22c2bbe.
…nsity/cpython into frameslocalsproxy-types
This reverts commit fee5256.
Should I test before I push my changes? Yes. Will I ever do it? No.
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Expose PEP-667's
FrameLocalsProxytype asFrameLocalsProxyTypein thetypesmodule.📚 Documentation preview 📚: https://cpython-previews--136546.org.readthedocs.build/en/136546/library/types.html#types.FrameLocalsProxyType