gh-89083: Add CLI tests for `UUIDv{6,7,8}` #136548

LamentXU123 · 2025-07-11T15:33:19Z

This PR add simple cli test cases to UUIDv6, v7, v8 added in #89083 , as well as a test case to UUID v1.

There are only one test cases for each, since they can't be customized through CLI.

Skipping news ;)

Issue: Support UUIDv6, UUIDv7, and UUIDv8 from RFC 9562 #89083

picnixz

Can you:

follow PEP-8 (1 blank line between functions)
make a separate class that is only testing the CLI functionality please?

LamentXU123 · 2025-07-11T16:12:13Z

follow PEP-8 (1 blank line between functions)
make a separate class that is only testing the CLI functionality please?

Done. Thanks!

Edited: btw, we've got tested like this:

class TestUUIDWithoutExtModule(BaseTestUUID, unittest.TestCase):
    uuid = py_uuid

In this current PR code, this test in redundant. I suggest maybe we could combine them together (?)

LamentXU123 · 2025-07-11T16:12:50Z

Lib/test/test_uuid.py

@@ -1140,6 +1140,9 @@ def test_uuid_weakref(self):
        weak = weakref.ref(strong)
        self.assertIs(strong, weak())

+
+class TestUUIDCli(BaseTestUUID, unittest.TestCase):


Do we need all CAPS on term CLI?

Just check how other classes testing CLIs are named.

picnixz

There is a lot of duplicated code. I would sugfgest having a single a single function that tests the expected outputs accordingly:

def do_test_standalone_uuid(self, version):
    stdout = io.StringIO()
    with contextlib.redirect_stdout(stdout):
        self.uuid.main()
    output = stdout.getvalue().strip()
    u = self.uuid.UUID(output)
    self.assertEqual(output, str(u))
    self.assertEqual(u.version, version)

@mock.patch.object(sys, "argv", ["", "-u", "uuid1"])
def test_uuid1(self):
    self.do_test_standalone_uuid(1)

and similar stuff for v6, v7 and v8.

Lib/test/test_uuid.py

LamentXU123 · 2025-07-11T16:23:46Z

follow PEP-8 (1 blank line between functions)
make a separate class that is only testing the CLI functionality please?

Done. Thanks!

Edited: btw, we've got tested like this:
class TestUUIDWithoutExtModule(BaseTestUUID, unittest.TestCase):
    uuid = py_uuid
In this current PR code, this test in redundant. I suggest maybe we could combine them together (?)

In the test case of cli we've actually already tested UUID without ext moudle (?, I'm not quiet sure) So maybe combining them together will be better?

picnixz · 2025-07-11T16:21:58Z

Lib/test/test_uuid.py

@@ -1140,6 +1140,9 @@ def test_uuid_weakref(self):
        weak = weakref.ref(strong)
        self.assertIs(strong, weak())

+
+class TestUUIDCli(BaseTestUUID, unittest.TestCase):


Just check how other classes testing CLIs are named.

Lib/test/test_uuid.py

picnixz · 2025-07-11T16:29:51Z

In the test case of cli we've actually already tested UUID without ext moudle (?, I'm not quiet sure) So maybe combining them together will be better?

In this current PR code, this test in redundant. I suggest maybe we could combine them together (?)

It's not entirely redundant. However I see the issue. Two possibilities:

Make the CLI test a mixin class that doesn't inherit from test case
Create two subclasses that are test cases, one with the extension module, one without.

Or:

Make CLI tests a mixin class that doesn't inhert from test cases, without a uuid field (you can add a dummy one just for autocompletion, but set it to None as it'll be subclassed later).
Make TestUUIDWithoutExtModule and TestUUIDWithExtModule inherit from this mixin as well (in addition to BaseTestUUID).

picnixz · 2025-07-11T16:32:12Z

Ok, actually CommandLineTest is a more common name in the code base. Just use it, no need to mention UUID (search for "CommandLineTest" and you'll see)

LamentXU123 · 2025-07-11T16:34:57Z

Ok, actually CommandLineTest is a more common name in the code base. Just use it, no need to mention UUID (search for "CommandLineTest" and you'll see)

The test classes before are named in testUUID* (which I think would be better if we add this prefix in this func). But yes CommandLineTest only is more common one in the code base so it's OK.

LamentXU123 · 2025-07-11T16:44:26Z

Make the CLI test a mixin class that doesn't inherit from test case
Create two subclasses that are test cases, one with the extension module, one without.

This is better IMO. I've changed it.

Lib/test/test_uuid.py

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Lib/test/test_uuid.py

LamentXU123 · 2025-07-12T12:08:09Z

Thanks! Should we backport this to 3.14? The new UUIDs are added in that version

miss-islington-app · 2025-07-12T12:08:53Z

Thanks @LamentXU123 for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

(cherry picked from commit c564847) Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-app · 2025-07-12T12:09:03Z

GH-136576 is a backport of this pull request to the 3.14 branch.

gh-89083: Add CLI tests for `UUIDv{6,7,8}` (GH-136548) (cherry picked from commit c564847) Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update test_uuid.py

609ab56

bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Jul 11, 2025

bedevere-app bot mentioned this pull request Jul 11, 2025

Support UUIDv6, UUIDv7, and UUIDv8 from RFC 9562 #89083

Closed

StanFromIreland added the skip news label Jul 11, 2025

Add a blank line

adfcc24

LamentXU123 changed the title ~~gh-89083: add cli tests for new UUID versions~~ gh-89083: Add cli tests for new UUID versions Jul 11, 2025

picnixz reviewed Jul 11, 2025

View reviewed changes

LamentXU123 added 2 commits July 12, 2025 00:10

add seperate class for cli tests

4e36078

add blank line

5d29f9e

LamentXU123 requested a review from picnixz July 11, 2025 16:11

LamentXU123 commented Jul 11, 2025

View reviewed changes

picnixz reviewed Jul 11, 2025

View reviewed changes

Lib/test/test_uuid.py Outdated Show resolved Hide resolved

Add standalone function for uuid tests

50996af

picnixz reviewed Jul 11, 2025

View reviewed changes

LamentXU123 added 2 commits July 12, 2025 00:25

Update test_uuid.py

73f8de9

Update test_uuid.py

d63e3a7

Change class name to TestUUIDCommandLineRunTime

0c2b231

LamentXU123 added 3 commits July 12, 2025 00:44

Make the CLI test a mixin class

142324a

Change back the class name

98234f3

Update test_uuid.py

3e4bf3c

picnixz reviewed Jul 11, 2025

View reviewed changes

Lib/test/test_uuid.py Outdated Show resolved Hide resolved

Update Lib/test/test_uuid.py

a873bf8

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

picnixz reviewed Jul 11, 2025

View reviewed changes

Lib/test/test_uuid.py Outdated Show resolved Hide resolved

Update test_uuid.py

a8d40ed

picnixz approved these changes Jul 11, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Jul 11, 2025

picnixz changed the title ~~gh-89083: Add cli tests for new UUID versions~~ gh-89083: Add CLI tests for UUIDv{6,7,8} Jul 11, 2025

picnixz changed the title ~~gh-89083: Add CLI tests for UUIDv{6,7,8}~~ gh-89083: Add CLI tests for UUIDv{6,7,8} Jul 11, 2025

picnixz merged commit c564847 into python:main Jul 12, 2025
43 checks passed

bedevere-app bot removed the awaiting merge label Jul 12, 2025

picnixz added the needs backport to 3.14 bugs and security fixes label Jul 12, 2025

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 12, 2025

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025

pythongh-89083: Add CLI tests for UUIDv{6,7,8} (python#136548)

a154f52

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Uh oh!

gh-89083: Add CLI tests for UUIDv{6,7,8} #136548

gh-89083: Add CLI tests for UUIDv{6,7,8} #136548

Conversation

LamentXU123 commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

LamentXU123 commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LamentXU123 Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

picnixz Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

picnixz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LamentXU123 commented Jul 11, 2025

Uh oh!

picnixz Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

picnixz commented Jul 11, 2025

Uh oh!

picnixz commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LamentXU123 commented Jul 11, 2025

Uh oh!

LamentXU123 commented Jul 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LamentXU123 commented Jul 12, 2025

Uh oh!

miss-islington-app bot commented Jul 12, 2025

Uh oh!

bedevere-app bot commented Jul 12, 2025

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

gh-89083: Add CLI tests for `UUIDv{6,7,8}` #136548

gh-89083: Add CLI tests for `UUIDv{6,7,8}` #136548

LamentXU123 commented Jul 11, 2025 •

edited

Loading

LamentXU123 commented Jul 11, 2025 •

edited

Loading

picnixz left a comment •

edited

Loading

picnixz commented Jul 11, 2025 •

edited

Loading