Skip to content

[DOC] Add development note for MacOS #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

[DOC] Add development note for MacOS #1066

merged 1 commit into from
Jun 10, 2025

Conversation

ikus060
Copy link
Contributor

@ikus060 ikus060 commented Apr 30, 2025

Changes done and why

Create a first version with MacOS documentation.

Self-Checklist

  • changes to the code have been reflected in the documentation
  • changes to the code have been covered by new/modified tests
  • commit contains a description of changes relevant to users prefixed by DOC:, FIX:, NEW: and/or CHG:

ericzolf
ericzolf requested changes Jun 5, 2025
View reviewed changes
Copy link
Member

@ericzolf ericzolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smaller things and the "global" fixes should go away. As a side remark, with code changes, you shouldn't use the [DOC] prefix! Rebase required as well.

src/rdiff_backup/run_stats.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global is already fixed.

@ikus060 ikus060 force-pushed the patrik-doc-macos branch from 3faab3e to 5d7d3b9 Compare June 8, 2025 23:24
@ikus060
Add development note for MacOS
69cd93c 
DOC: Add development note for MacOS

Closes #995

Signed-off-by: Patrik Dufresne <patrik@ikus-soft.com>
@ikus060 ikus060 force-pushed the patrik-doc-macos branch from 5d7d3b9 to 69cd93c Compare June 8, 2025 23:30
@ikus060
Copy link
Contributor Author

ikus060 commented Jun 8, 2025

@ericzolf Thanks for your feedback. I've update the documentation.

@ericzolf ericzolf self-requested a review June 10, 2025 06:48
ericzolf
ericzolf approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@ericzolf ericzolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericzolf ericzolf merged commit c6988e8 into master Jun 10, 2025
8 checks passed
@ericzolf ericzolf deleted the patrik-doc-macos branch June 10, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericzolf ericzolf ericzolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikus060 @ericzolf
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy