Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ActionItems to be directly specified between the ActionBar opening and closing tags. #518

Closed
PanayotCankov opened this issue Jul 30, 2015 · 4 comments
Closed

Allow ActionItems to be directly specified between the ActionBar opening and closing tags. #518

PanayotCankov opened this issue Jul 30, 2015 · 4 comments
Labels
bug done severity: high
Milestone
1.6.0

Comments

@PanayotCankov
Copy link
Contributor

The silly me put this on a page:

  <Page.actionBar>
    <ActionBar>
      <ActionItem text="{{ resources.signUp }}" tap="signUpMenuItemTap" android.position="actionBar" />
    </ActionBar>
  </Page.actionBar>

At runtime it works like a charm. The only problem is the action item does not appear.

Obviously the correct usage is:

  <Page.actionBar>
    <ActionBar>
      <ActionBar.actionItems>
        <ActionItem text="{{ resources.signUp }}" tap="signUpMenuItemTap" android.position="actionBar" />
      </ActionBar.actionItems>
    </ActionBar>
  </Page.actionBar>

The problem is the first case does not generate neither compile-time nor run-time error.
@ligaz
Copy link
Contributor

ligaz commented Jul 31, 2015

See here for a possible solution.

@PanayotCankov
Copy link
Contributor Author

I would agree to have both decorators marking the content properties and errors/warnings. However when you look at the issues - the snippets are identical but the problems are different.

@enchev enchev mentioned this issue Oct 16, 2015
Closed
@enchev enchev closed this as completed Oct 16, 2015
@enchev
Copy link
Contributor

enchev commented Oct 16, 2015

Merged with this: #597

@valentinstoychev valentinstoychev added this to the 1.6.0 (Under Review) milestone Nov 27, 2015
@hamorphis hamorphis self-assigned this Dec 16, 2015
@hamorphis hamorphis changed the title Better XML declaration error reporting for unacceptable content Allow ActionItems to be specified directly between the ActionBar opening and closing tags. Dec 16, 2015
@hamorphis hamorphis changed the title Allow ActionItems to be specified directly between the ActionBar opening and closing tags. Allow ActionItems to be directly specified between the ActionBar opening and closing tags. Dec 16, 2015
hamorphis added a commit that referenced this issue Dec 16, 2015
@hamorphis
Fixed Issue #518: Allow ActionItems to be directly specified between …
1bd52ef 
…the ActionBar opening and closing tags.
hamorphis added a commit that referenced this issue Dec 17, 2015
@hamorphis
Merge pull request #1263 from NativeScript/issue-518
cbf69e6 
Fixed Issue #518:  Allow ActionItems to be directly specified between…
@lock
Copy link

lock bot commented Aug 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot unassigned hamorphis Aug 30, 2019
@lock lock bot locked and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug done severity: high
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
5 participants
@ligaz @hamorphis @valentinstoychev @enchev @PanayotCankov
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy