Skip to content

Commit ebc9525

Browse files
langchr86dpgeorge
authored andcommitted
rp2/modmachine: Do not use deprecated XOSC_MHZ and XOSC_KHZ.
XOSC_MHZ and XOSC_KHZ may not be defined if we use a custom XIN clock by defining PLL_SYS_REFDIV etc. calculated by vcocalc.py. Signed-off-by: Christian Lang <lang.chr86@gmail.com>
1 parent ab620f4 commit ebc9525

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

ports/rp2/clocks_extra.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ void runtime_init_clocks_optional_usb(bool init_usb) {
8383
clock_configure(clk_ref,
8484
CLOCKS_CLK_REF_CTRL_SRC_VALUE_XOSC_CLKSRC,
8585
0, // No aux mux
86-
XOSC_KHZ * KHZ,
87-
XOSC_KHZ * KHZ);
86+
XOSC_HZ,
87+
XOSC_HZ);
8888

8989
/// \tag::configure_clk_sys[]
9090
// CLK SYS = PLL SYS (usually) 125MHz / 1 = 125MHz

ports/rp2/modmachine.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,6 @@ static void mp_machine_lightsleep(size_t n_args, const mp_obj_t *args) {
163163
}
164164
}
165165

166-
const uint32_t xosc_hz = XOSC_MHZ * 1000000;
167-
168166
uint32_t my_interrupts = MICROPY_BEGIN_ATOMIC_SECTION();
169167
#if MICROPY_PY_NETWORK_CYW43
170168
if (cyw43_poll_is_pending()) {
@@ -200,18 +198,18 @@ static void mp_machine_lightsleep(size_t n_args, const mp_obj_t *args) {
200198
#endif
201199

202200
// CLK_REF = XOSC
203-
clock_configure(clk_ref, CLOCKS_CLK_REF_CTRL_SRC_VALUE_XOSC_CLKSRC, 0, xosc_hz, xosc_hz);
201+
clock_configure(clk_ref, CLOCKS_CLK_REF_CTRL_SRC_VALUE_XOSC_CLKSRC, 0, XOSC_HZ, XOSC_HZ);
204202

205203
// CLK_SYS = CLK_REF
206-
clock_configure(clk_sys, CLOCKS_CLK_SYS_CTRL_SRC_VALUE_CLK_REF, 0, xosc_hz, xosc_hz);
204+
clock_configure(clk_sys, CLOCKS_CLK_SYS_CTRL_SRC_VALUE_CLK_REF, 0, XOSC_HZ, XOSC_HZ);
207205

208206
// CLK_RTC = XOSC / 256
209207
#if PICO_RP2040
210-
clock_configure(clk_rtc, 0, CLOCKS_CLK_RTC_CTRL_AUXSRC_VALUE_XOSC_CLKSRC, xosc_hz, xosc_hz / 256);
208+
clock_configure(clk_rtc, 0, CLOCKS_CLK_RTC_CTRL_AUXSRC_VALUE_XOSC_CLKSRC, XOSC_HZ, XOSC_HZ / 256);
211209
#endif
212210

213211
// CLK_PERI = CLK_SYS
214-
clock_configure(clk_peri, 0, CLOCKS_CLK_PERI_CTRL_AUXSRC_VALUE_CLK_SYS, xosc_hz, xosc_hz);
212+
clock_configure(clk_peri, 0, CLOCKS_CLK_PERI_CTRL_AUXSRC_VALUE_CLK_SYS, XOSC_HZ, XOSC_HZ);
215213

216214
// Disable PLLs.
217215
pll_deinit(pll_sys);

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy