Merge pull request #312 from sebadob/client-contacts-uri-logos

Add `client_uri` + `contacts` and migrate `client_logos` logic
sebadob · Apr 13, 2024 · 6ccc541 · 6ccc541
2 parents 5a36953 + 34c09a3
commit 6ccc541
Show file tree

Hide file tree

Showing 25 changed files with 1,421 additions and 704 deletions.
diff --git a/dev_notes.md b/dev_notes.md
@@ -4,8 +4,12 @@
 
 ## TODO before v0.22
 
+- validate `db_migrate` is formed correctly after all the new migrations
+  sqlite -> postgres -> sqlite again
 - maybe migrate the old client logos handling to the new optimized webp flow?
+- add `contact` and `application_url` to the `clients` table for future features
 - document "Login with Github" guide
+- specifically set cache headers on client logos
 
 ## Stage 1 - essentials
 
@@ -19,6 +23,11 @@
 - benchmarks and performance tuning
 - maybe get a nicer logo
 
+### Notes for performance optimizations
+
+- all the `get_`s on the `Client` will probably be good with returning slices instead of real Strings -> less memory
+  allocations
+
 ## Stage 3 - Possible nice to haves
 
 - respect `display=popup` and / or `display=touch` on `/authorize`

diff --git a/frontend/src/components/ClientLogo.svelte b/frontend/src/components/ClientLogo.svelte
@@ -0,0 +1,12 @@
+<script>
+    import {getKey} from "$lib/utils/helpers.js";
+
+    export let clientId;
+</script>
+
+<!--
+We append a random param here to force the browser to do a refetch, if the logo has been changed.
+This is only needed for the Admin UI, when we upload a new version of the image.
+Without this (unused) query param, the browser would never reload the <img> tag.
+-->
+<img src="{`/auth/v1/clients/${clientId}/logo?${getKey(6)}`}" alt="No Logo Available"/>
diff --git a/frontend/src/components/ProviderLogo.svelte b/frontend/src/components/ProviderLogo.svelte
@@ -0,0 +1,12 @@
+<script>
+    import {getKey} from "$lib/utils/helpers.js";
+
+    export let providerId;
+</script>
+
+<!--
+We append a random param here to force the browser to do a refetch, if the logo has been changed.
+This is only needed for the Admin UI, when we upload a new version of the image.
+Without this (unused) query param, the browser would never reload the <img> tag.
+-->
+<img src="{`/auth/v1/providers/${providerId}/img?${getKey(6)}`}" width={20} height={20} alt="No Logo Available"/>