Skip to content

chore: migrate to getCurrentInstance API #12958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: migrate to getCurrentInstance API #12958

wants to merge 1 commit into from

Conversation

OnlyWick
Copy link
Contributor

Found a missed spot to use getCurrentInstance API instead of direct instance access.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 27, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12958

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12958

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12958

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12958

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12958

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12958

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12958

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12958

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12958

vue

npm i https://pkg.pr.new/vue@12958

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12958

commit: 7789361

@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (-4 B) 38.1 kB (+1 B) 34.3 kB (+6 B)
vue.global.prod.js 158 kB (-4 B) 58 kB 51.6 kB (-21 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.5 kB 18.2 kB 16.7 kB
createApp 54.6 kB (+12 B) 21.3 kB (+12 B) 19.4 kB (+7 B)
createSSRApp 58.8 kB (+12 B) 23 kB (+5 B) 21 kB (+7 B)
defineCustomElement 59.4 kB (+12 B) 22.9 kB (+3 B) 20.8 kB (+5 B)
overall 68.6 kB (-2 B) 26.4 kB 24 kB (-35 B)

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🧹 p1-chore Priority 1: this doesn't change code behavior. labels Feb 27, 2025
@edison1105 edison1105 changed the title refactor: migrate to getCurrentInstance API chore: migrate to getCurrentInstance API Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazariEX KazariEX KazariEX approved these changes

Assignees
No one assigned
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. ready to merge The PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OnlyWick @KazariEX @edison1105
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy