Page MenuHomePhabricator
Create Task
Maniphest T218459

Schemas aren't parser cached
Closed, ResolvedPublic
Actions

Description

Earlier today I noticed that changes I did to the code generating Schema html were reflected in my wiki pages immediately (without the usual purging): Apparently we don't parser cache schemas right now. Looking into the html source also shows that the <!-- Saved in parser cache with key … and timestamp 20190313004841 and revision id 58 which ParserCache::save prepends to the output html is missing.

Details

SubjectRepoBranchLines +/-
Add isParserCacheSupported -> truemediawiki/extensions/WikibaseSchemamaster+15 -0
Customize query in gerrit

Related Objects

Event Timeline

hoo created this task.Mar 16 2019, 1:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2019, 1:09 AM
hoo moved this task from Backlog to Doing on the Shape Expressions Sprint 4 board.Mar 16 2019, 1:09 AM
gerritbot subscribed.Mar 16 2019, 1:17 AM

Change 497017 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/WikibaseSchema@master] Add isParserCacheSupported -> true

https://gerrit.wikimedia.org/r/497017

gerritbot added a project: Patch-For-Review.Mar 16 2019, 1:17 AM
hoo claimed this task.Mar 16 2019, 1:18 AM
hoo moved this task from Doing to Peer Review on the Shape Expressions Sprint 4 board.
gerritbot added a comment.Mar 20 2019, 9:38 AM

Change 497017 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Add isParserCacheSupported -> true

https://gerrit.wikimedia.org/r/497017

Michael moved this task from Peer Review to Verification on the Shape Expressions Sprint 4 board.Mar 20 2019, 9:43 AM
Lucas_Werkmeister_WMDE mentioned this in T218769: “Edit” links on newly created schemas are red.Mar 20 2019, 11:40 AM
Lea_Lacroix_WMDE closed this task as Resolved.Mar 21 2019, 9:01 AM
Lea_Lacroix_WMDE moved this task from Verification to Done on the Shape Expressions Sprint 4 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy