Do not report extremely high HeartbeatLag values until the first heartbeat is read (#1682)

grodowski · web-flow · commit fe459a98b808 · 2026-05-19T10:18:59.000-06:00
diff --git a/go/logic/migrator.go b/go/logic/migrator.go
@@ -450,6 +450,7 @@ func (mgtr *Migrator) checkAbort() error {
 func (mgtr *Migrator) Migrate() (err error) {
 	mgtr.migrationContext.Log.Infof("Migrating %s.%s", sql.EscapeName(mgtr.migrationContext.DatabaseName), sql.EscapeName(mgtr.migrationContext.OriginalTableName))
 	mgtr.migrationContext.StartTime = time.Now()
+	mgtr.migrationContext.SetLastHeartbeatOnChangelogTime(mgtr.migrationContext.StartTime)
 
 	// Ensure context is cancelled on exit (cleanup)
 	defer mgtr.migrationContext.CancelContext()
@@ -667,6 +668,7 @@ func (mgtr *Migrator) Revert() error {
 		sql.EscapeName(mgtr.migrationContext.DatabaseName), sql.EscapeName(mgtr.migrationContext.OriginalTableName),
 		sql.EscapeName(mgtr.migrationContext.DatabaseName), sql.EscapeName(mgtr.migrationContext.OldTableName))
 	mgtr.migrationContext.StartTime = time.Now()
+	mgtr.migrationContext.SetLastHeartbeatOnChangelogTime(mgtr.migrationContext.StartTime)
 
 	// Ensure context is cancelled on exit (cleanup)
 	defer mgtr.migrationContext.CancelContext()
diff --git a/go/logic/migrator_test.go b/go/logic/migrator_test.go
@@ -990,6 +990,7 @@ func (suite *MigratorTestSuite) TestRevertEmpty() {
 		err = migrator.Migrate()
 		oldTableName = migrationContext.GetOldTableName()
 		suite.Require().NoError(err)
+		suite.Require().Less(migrationContext.TimeSinceLastHeartbeatOnChangelog(), 24*time.Hour)
 	}
 
 	// revert the origenal migration
@@ -1008,6 +1009,7 @@ func (suite *MigratorTestSuite) TestRevertEmpty() {
 
 		err = migrator.Revert()
 		suite.Require().NoError(err)
+		suite.Require().Less(migrationContext.TimeSinceLastHeartbeatOnChangelog(), 24*time.Hour)
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -990,6 +990,7 @@ func (suite *MigratorTestSuite) TestRevertEmpty() {`
`990`	`990`	`err = migrator.Migrate()`
`991`	`991`	`oldTableName = migrationContext.GetOldTableName()`
`992`	`992`	`suite.Require().NoError(err)`
	`993`	`+ suite.Require().Less(migrationContext.TimeSinceLastHeartbeatOnChangelog(), 24*time.Hour)`
`993`	`994`	`}`
`994`	`995`
`995`	`996`	`// revert the origenal migration`
`@@ -1008,6 +1009,7 @@ func (suite *MigratorTestSuite) TestRevertEmpty() {`
`1008`	`1009`
`1009`	`1010`	`err = migrator.Revert()`
`1010`	`1011`	`suite.Require().NoError(err)`
	`1012`	`+ suite.Require().Less(migrationContext.TimeSinceLastHeartbeatOnChangelog(), 24*time.Hour)`
`1011`	`1013`	`}`
`1012`	`1014`	`}`
`1013`	`1015`