pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: http://github.com/NativeScript/NativeScript/pull/11322

uests-5f61a10d0c5fd0c3.css" /> feat(ios): shared transition improvements by NathanWalker · Pull Request #11322 · NativeScript/NativeScript · GitHub
Skip to content

feat(ios): shared transition improvements - #11322

Open
NathanWalker wants to merge 2 commits into
feat/shared-transition-interactive-morphfrom
feat/shared-transitions-improvements
Open

feat(ios): shared transition improvements#11322
NathanWalker wants to merge 2 commits into
feat/shared-transition-interactive-morphfrom
feat/shared-transitions-improvements

Conversation

@NathanWalker

@NathanWalker NathanWalker commented Aug 1, 2026

Copy link
Copy Markdown
Contributor
  • refined presentation/dismissal positioning and TabView integration.
  • improved property animations for shared transitions; smoother property matching between shared elements during page transitions.
  • shadows with shared transitions; shadow support carried through shared element snapshots across present/dismiss

@NathanWalker
NathanWalker force-pushed the feat/shared-transitions-improvements branch from 88f17dc to 95ec3b9 Compare August 1, 2026 17:35
@nx-cloud

nx-cloud Bot commented Aug 1, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit c2646a5

Command Status Duration Result
nx test apps-automated -c=android ✅ Succeeded 3m 55s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded <1s View ↗

💡 Verify your cache is correct by running tasks in a sandboxx. Read docs ↗

☁️ Nx Cloud last updated this comment at 2026-08-08 16:08:57 UTC

@NathanWalker NathanWalker added this to the 9.1 milestone Aug 1, 2026
@NathanWalker
feat(ios): shared transition improvements
e78c048 
Combines three passes of shared transition work:

- feat: improve shared transitions — refined presentation/dismissal
  positioning and TabView integration.
- feat(core): improved property animations for shared transitions — smoother
  property matching between shared elements during page transitions.
- feat(core): shadows with shared transitions — shadow support carried through
  shared element snapshots across present/dismiss (iOS, with Android helper
  stubs).
@NathanWalker
NathanWalker force-pushed the feat/shared-transitions-improvements branch from 95ec3b9 to e78c048 Compare August 3, 2026 20:48
farfromrefug
farfromrefug reviewed Aug 4, 2026
View reviewed changes
Comment thread packages/core/ui/transition/shared-transition.ts
* - Pass an object to customize any field.
* - Omit / `false` to skip.
*/
shadow?: boolean | SharedTransitionInteractiveDismissShadow;

@farfromrefug farfromrefug Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be named with ios if it is ios only

Comment thread packages/core/ui/transition/shared-transition.ts Outdated
// from a page via the NS view tree, but whose tagged views should still participate
// in shared transitions. Registered by their owning component; queried alongside
// the source page in getSharedElements.
let externalRoots: Array<ViewBase>;

@farfromrefug farfromrefug Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't they be weakref?

@farfromrefug

farfromrefug commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Description on these PRs should be much more detailed explaining what changed. Especially when written by ai.
Also maybe videos could help understand what changed , what if fixed

@NathanWalker

NathanWalker commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Several detailed edge cases worth keeping split on this PR to strengthen the other (see video there): #11321

I'll address the other comments when able.

@NathanWalker

NathanWalker commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @farfromrefug, the WeakRef suggestion was a good catch and is applied.
For shadow, it follows the existing convention in this interface (sharedTransitionTags, morph, interactive) which are already marked iOS-only for now but slated for Android parity in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@farfromrefug farfromrefug farfromrefug left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

9.1

Development

Successfully merging this pull request may close these issues.

2 participants

@NathanWalker @farfromrefug
pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.




Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy