Replace deprecated chrono with jiff - #8436
Merged
youknowone merged 1 commit intoAug 4, 2026
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (6)
📝 WalkthroughWalkthroughThe PR replaces ChangesJiff time migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
joshuamegnauth54
marked this pull request as ready for review
August 3, 2026 16:31
joshuamegnauth54
force-pushed
the
replace-deprecated-chrono
branch
from
August 3, 2026 16:31
9e4ff33 to
55e14ab
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/vm/src/stdlib/time.rs`:
- Around line 429-432: Complete the Jiff migration in
OptionalArg::naive_or_local and the related non-Unix/non-Windows time
constructors: return Zoned instead of NaiveDateTime, pass tm.datetime() to
StructTimeData::new_inner, and update new_local to use the assigned tm value
rather than the undefined tz reference.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro Plus
Run ID: 4709810b-04e7-4b17-a427-d7509f6b2732
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
Cargo.tomlcrates/stdlib/Cargo.tomlcrates/stdlib/src/ssl/cert.rscrates/vm/Cargo.tomlcrates/vm/build.rscrates/vm/src/stdlib/time.rs
joshuamegnauth54
force-pushed
the
replace-deprecated-chrono
branch
from
August 3, 2026 17:04
55e14ab to
92a0412
Compare
joshuamegnauth54
force-pushed
the
replace-deprecated-chrono
branch
from
August 4, 2026 00:14
92a0412 to
84687d0
Compare
youknowone
approved these changes
Aug 4, 2026
youknowone
left a comment
youknowone
left a comment
Member
There was a problem hiding this comment.
Thanks, didn't know chrono is going to be deprecated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: chronotope/chrono#1768
Summary
Summary by CodeRabbit