Add forward declaration header - #3725
Open
ZXShady wants to merge 1 commit into
Open
Conversation
A lot of code online does manual forward declarations of our classes, this is bad for us since it makes changing implementation details unnecessarily harder e.g a simple change from `class` to `struct` can cause linker errors on msvc, having official ways to forward declare our types prevent these issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of code online does manual forward declarations of our classes, this is bad for us since it makes changing implementation details unnecessarily harder e.g a simple change from
classtostructcan cause linker errors on msvc, having official ways to forward declare our types prevent these issues and allows stuff like adding inline namespaces for versioning purposes.Also having these headers removes our manual forward declarations as well.
These are some searches of users manually doing it this alone shows 8k uses
https://github.com/search?q=%2Fnamespace%20sf%5Cs*%5C%7B%5Cs*%5Cn%5Cs*(class%7Cstruct)%2F%20NOT%20repo%3Asfml%2FSFML%20language%3AC%2B%2B&type=code
I am making a pr to have a discussion.