refactor: database name display - #21097
Conversation
# Conflicts: # frontend/src/routes/project/issue-detail/components/IssueDetailDatabaseExportView.tsx
|
The current
My vote goes to the slash |
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b7b2ce974e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| text={environment.title} | ||
| className={cn("mr-1 min-w-0 shrink", classes.environment)} | ||
| > | ||
| <EnvironmentLabel environment={environment} /> |
There was a problem hiding this comment.
When showEnvironment is enabled in row-heavy consumers such as DatabaseResourceSelector (up to 200 rows per page), every target now mounts EnvironmentLabel. Even when the resolved environment object is passed, that component unconditionally calls both useEnvironment() and usePlanFeature(), registering multiple Zustand subscriptions and running loadEnvironmentList() and loadSubscription() effects for every row. This recreates the per-row loading/subscription pattern that DatabaseTableView explicitly hoists to avoid; use the pure EnvironmentBadge with hoisted feature/environment data, or otherwise provide a pure display path for list consumers.
Useful? React with 👍 / 👎.
2 participants
{Engine icon} {Instance title} > {Environment label} {Database name}
Close BYT-9823 and BYT-9933
Before
After