fix: keep reversed scale titles aligned - #12244
Open
d3v07 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes axis title alignment so reversing a cartesian scale no longer flips title.align (“start”/“end”) to the opposite end, and adds a regression test for the behavior.
Changes:
- Update internal
titleAlignlogic soreverseno longer influences title text alignment. - Add regression tests asserting title draw calls are identical for
reverse: truevsreverse: falseacross cartesian edge positions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/core/core.scale.js |
Removes reverse from title alignment calculation to keep start/end alignment stable when scales are reversed. |
test/specs/core.scale.tests.js |
Adds a regression test comparing captured title draw calls between reversed and non-reversed scales for align: 'start'/'end'. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
122
to
127
| function titleAlign(align, position) { | ||
| /** @type {CanvasTextAlign} */ | ||
| let ret = _toLeftRightCenter(align); | ||
| if ((reverse && position !== 'right') || (!reverse && position === 'right')) { | ||
| if (position === 'right') { | ||
| ret = reverseAlign(ret); | ||
| } |
Comment on lines
+890
to
+893
| ['top', 'bottom', 'left', 'right'].forEach(function(position) { | ||
| ['start', 'end'].forEach(function(align) { | ||
| it('should not reposition the ' + position + ' scale title when reverse=true and align=' + align, function() { | ||
| expect(getScaleTitleCalls(position, align, true)).toEqual(getScaleTitleCalls(position, align, false)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
align: 'start'andalign: 'end'across cartesian scale positionsFixes #12239
Repro
Verification
pnpm run buildpnpm exec eslint src/core/core.scale.js test/specs/core.scale.tests.jsreverseno longer changes the title draw calls foralign=startoralign=end