Fix skill updates for hidden source paths - #13963
Closed
naufalfx805-source wants to merge 1 commit into
Closed
Conversation
github-actions
Bot
added
external
naufalfx805-source
marked this pull request as ready for review
July 24, 2026 15:14
github-actions
Bot
added
unmet-requirements
and removed
needs-triage
Contributor
|
Thanks for your pull request! Unfortunately, it doesn't meet the requirements for review:
Please update your PR to address the above. This PR will be automatically closed in 4 days if these requirements are not met. Full contribution requirements
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes path-based skill updates for installed skills whose recorded GitHub path contains hidden directory segments such as
.curated.When an installed skill has
github-pathmetadata with a hidden segment,gh skill update --allnow resolves that exact path withDiscoverSkillByPathWithOptionsinstead of relying on repository-wide discovery that skips hidden directories by default.Fixes #13542.
Validation
go test ./internal/skills/discovery ./pkg/cmd/skills/update