Refs #36036 -- Added support for M dimension geometries. - #21652
Draft
smithdc1 wants to merge 2 commits into
Draft
Refs #36036 -- Added support for M dimension geometries.#21652smithdc1 wants to merge 2 commits into
smithdc1 wants to merge 2 commits into
Conversation
…r GEOS Point and LineString. Used GEOSCoordSeq_copyFromBuffer to create CoordSeq in bulk. This avoids a C API call per ordinate. GEOSCoordSeq_copyFromBuffer also has 'hasZ' and 'hasM' arguments which will be useful when adding M dimension support. GEOSCoordSeq_create is limited in that it assumes that the third ordinate is always Z. This may not always be the case.
jacobtylerwalls
changed the title
smithdc1
force-pushed
the
gis-4dim-support
branch
from
July 23, 2026 07:46
9a8456d to
a1e5ddf
Compare
Member
Author
|
I'm not sure why the test skips are not working 🤔. Atleast the |
ngnpope
reviewed
Jul 24, 2026
| if f.dim == 4: | ||
| geom_type = f.geom_type + "ZM" | ||
| elif f.dim == 3: | ||
| geom_type = f.geom_type + "Z" |
Member
There was a problem hiding this comment.
Drive by comment... Could this not also be:
geom_type = f.geom_type + "M"How would we distinguish that here?
Member
Author
There was a problem hiding this comment.
yes, nice 👍
To support M fields GeometryField could learn something like has_m which defaults to False. [insert many thinking emojis]
class PointModel()
point = fields.PointField(dim=3, has_m=True)
10 tasks
smithdc1
commented
Jul 27, 2026
| cs_ptr = capi.coordseq_from_buffer( | ||
| coords_buffer, | ||
| ncoords, | ||
| int(ndim >= 3), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ticket-36036
Branch description
I see the work to add M dimension geometry support to databases being made up of 3 steps:
This PR is a draft PR showing the current thinking on the overall patch. My thinking being is that steps 1 and 2 will be easier to review in context of some view of where I think we're headed.
Once the PR for step 1 is merged, I can update this and then pull out the changes for GEOS into a separate PR. Likely with some more polish ✨ .
AI Assistance Disclosure (REQUIRED)
Checklist
mainbranch.