feat: Add RemoveUnusedDeclarations - #1263
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
6e0d142 to
304839c
Compare
ReplaceObsoletesStepRemoveUnusedDeclarations
3e2ecb4 to
83b6daa
Compare
|
google seems dead. |
|
@Pankraz76, for future reference, Google employees can't even look at your PR until you accept the CLA. |
|
its signed:
Agreement Name Date Signed Manage |
|
as every tweak encountered here is fixed in palantir, consider google dead and will drop accordingly: |
83b6daa to
6dfcb65
Compare
feat: Add
RemoveUnusedDeclarationsformatting ruleThis PR introduces a new Java formatting rule that automatically removes redundant modifiers and declarations that are either:
Motivation
During codebase modernization efforts (#2524), we identified recurring patterns where:
publicin interfaces)final staticinstead ofstatic final)As highlighted in this comment, such redundancies:
Key Features
The rule handles:
Interface members:
public,static,final,abstractmodifierspublic static final int CONST→int CONSTNested types:
public static class Inner→static class InnerEnum declarations:
public static final VALUE→VALUEModern Java features:
public finalparams → implicit)Annotation declarations:
@interfaceformatting)Benefits
Reduced Noise:
Maintenance Efficiency:
Modern Java Support:
Non-intrusive:
Implementation Notes
privatewhen meaningful)@Nullable finalparametersIntegration
Works seamlessly with: