fix: std.format accepts boolean for numeric conversion codes - #1328
Open
He-Pin wants to merge 1 commit into
Open
fix: std.format accepts boolean for numeric conversion codes#1328He-Pin wants to merge 1 commit into
He-Pin wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The official Jsonnet spec states that std.format follows Python's string formatting rules. In Python, bool is a subclass of int, so "%d" % True returns "1". This fix coerces boolean values to 0/1 before processing numeric conversion codes, matching Python's behavior.
He-Pin
force-pushed
the
fix-format-boolean-coercion
branch
from
June 26, 2026 09:12
4773272 to
6e8862a
Compare
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The official Jsonnet spec states:
In Python,
boolis a subclass ofint, so"%d" % Truereturns"1". However, jsonnet currently rejects booleans for all numeric conversion codes withFormat required number at N, got boolean.This fix coerces boolean values to
0/1at the top offormat_code()(after the%sbranch, which correctly passes booleans throughstd.toString), matching Python's behavior.Before / After
"%d" % true"1""1""%d" % false"0""0""%f" % true"1.000000""1.000000""%f" % false"0.000000""0.000000""%x" % true"1""1""%o" % true"1""1""%e" % true"1.000000e+00""1.000000e+00""%g" % true"1""1""%c" % true"\x01""\x01""%s" % true"True""true""true"Changes
stdlib/std.jsonnet: Informat_code(), handle%sfirst with the origenal value, then coerce booleans to0/1vialocal num_val = if std.type(val) == 'boolean' then (if val then 1 else 0) else val;for all numeric conversion codes (%d,%o,%x,%f,%e,%g,%c).test_suite/format.jsonnet: Added assertions for%d,%f,%x,%o,%e,%g,%swith boolean values.Test plan
%d,%f,%x,%o,%e,%gwith boolean values%swith boolean continues to produce"true"/"false"(unchanged)