pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: http://github.com/graphprotocol/graph-node/pull/6622

quests-be6017ec12798e73.css" /> fix(gnd): surface anyhow error chains in error output by mvanhorn · Pull Request #6622 · graphprotocol/graph-node · GitHub
Skip to content

fix(gnd): surface anyhow error chains in error output - #6622

Open
mvanhorn wants to merge 1 commit into
graphprotocol:masterfrom
mvanhorn:fix/6360-gnd-error-chain-display
Open

fix(gnd): surface anyhow error chains in error output#6622
mvanhorn wants to merge 1 commit into
graphprotocol:masterfrom
mvanhorn:fix/6360-gnd-error-chain-display

Conversation

@mvanhorn

Copy link
Copy Markdown

Summary

gnd error output now surfaces the full anyhow error chain instead of only the top-level message. The bare {} Display formattings in main.rs and watch.rs printed just the outermost context (for example failed to load manifest), hiding the underlying cause a developer needs to act on; they now use the alternate {:#} chain rendering. The two bare serde_yaml::from_str()? sites in commands/build.rs and manifest.rs gain context so YAML parse failures name the file being parsed.

Why this matters

Issue #6360 reports that gnd swallows error causes, leaving developers with messages like Error: failed to start watch mode and no underlying reason. The silenced chains were verified at main.rs:266 and watch.rs:49/104 before the change. This covers the error-display half of the issue; the issue also discusses restructuring some error sites to attach more context at creation time, which is a larger refactor left for a follow-up.

Testing

A new unit test asserts a manifest parse failure renders with its cause chain (file name + YAML error) rather than the bare context string. cargo fmt --check and cargo check -p gnd pass; the new manifest error-chain test passes.

Refs #6360

@lutter

lutter commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the contribution. Can you rebase this to latest master?

@mvanhorn
mvanhorn force-pushed the fix/6360-gnd-error-chain-display branch from d80bbc9 to 06108c6 Compare July 4, 2026 02:40
@mvanhorn

mvanhorn commented Jul 4, 2026

Copy link
Copy Markdown
Author

Rebased onto latest master in 06108c6 - clean rebase, no conflicts, same single commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.





Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy