Description

Fixes #20964

This PR fixes the handling of negative pageSize values in the shared getPaginationParams() helper.

While testing the connection definitions endpoint, I found that a negative page size such as:

GET /api/meshmodels/connections?pagesize=-1

was parsed successfully by strconv.Atoi() and passed downstream as limit = -1.

The existing pagination validation only handled limit == 0:

if limit == 0 {
    limit = defaultPageSize
}

When the negative value reached GORM as Limit(-1), GORM removed the limit condition, causing the complete result set to be returned. The response also reported "pageSize": -1.

This change normalizes non-positive numeric page sizes to defaultPageSize:

if limit <= 0 {
    limit = defaultPageSize
}

The special pageSize=all behavior remains unchanged because it bypasses this normalization block and continues to use limit = 0.

The helper supports both the canonical pageSize parameter and the legacy pagesize spelling, so regression coverage includes both.

Current Behavior

Before the fix:

REQUEST:
GET /api/meshmodels/connections?pagesize=-1

HTTP: 200

{
  "page": 0,
  "pageSize": -1,
  "totalCount": 3,
  "returnedDefinitions": 3
}

A negative page size removes the query limit and the API reports an invalid negative pageSize.

Expected Behavior

Negative numeric page sizes should fall back to the default page size, consistent with zero and malformed page-size values.

After the fix:

REQUEST:
GET /api/meshmodels/connections?pagesize=-1

HTTP: 200

{
  "page": 0,
  "pageSize": 25,
  "totalCount": 26,
  "returnedDefinitions": 25
}

The number of connection definitions in my local environment increased between the before and after runs. The relevant values here are the reported pageSize and the number of returned definitions relative to the requested page size.

No Regression

Positive page sizes continue to work as expected:

REQUEST:
GET /api/meshmodels/connections?pagesize=1

HTTP: 200

{
  "page": 0,
  "pageSize": 1,
  "totalCount": 26,
  "returnedDefinitions": 1
}

The existing unlimited behavior is also preserved:

REQUEST:
GET /api/meshmodels/connections?pagesize=all

HTTP: 200

{
  "page": 0,
  "pageSize": 26,
  "totalCount": 26,
  "returnedDefinitions": 26
}

Tests

Added table-driven regression coverage for:

• canonical pageSize=-1
• legacy pagesize=-1
• pageSize=0
• malformed pageSize=abc
• positive pageSize=1
• pageSize=all

Test result:

=== RUN   TestGetPaginationParams
=== RUN   TestGetPaginationParams/negative_canonical_pageSize_defaults
=== RUN   TestGetPaginationParams/negative_legacy_pagesize_defaults
=== RUN   TestGetPaginationParams/zero_pageSize_defaults
=== RUN   TestGetPaginationParams/malformed_pageSize_defaults
=== RUN   TestGetPaginationParams/positive_pageSize_preserved
=== RUN   TestGetPaginationParams/all_preserves_unlimited_behavior
--- PASS: TestGetPaginationParams (0.00s)
PASS
ok      github.com/meshery/meshery/server/handlers      1.194s

Notes

The fix is made in the shared pagination helper rather than in the connection definitions handler, so invalid negative page sizes are normalized at the point where pagination parameters are parsed.

No changes are made to MeshKit's ConnectionFilter behavior or to the existing pageSize=all semantics.

Summary by CodeRabbit

• Bug Fixes

  • Invalid pagination pageSize values (including zero and negative/ non-positive inputs) now consistently fall back to the default page size.
  • Positive pageSize and pageSize=all (unlimited) behavior remain unchanged.

• Tests

  • Added unit test coverage for pagination pageSize handling across valid, invalid (malformed/negative), zero, and unlimited inputs.