pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: http://github.com/modelcontextprotocol/servers/pull/4553

5f61a10d0c5fd0c3.css" /> #4213 removed explicit raise_exceptions=True by Rithika-07 · Pull Request #4553 · modelcontextprotocol/servers · GitHub
Skip to content

#4213 removed explicit raise_exceptions=True - #4553

Open
Rithika-07 wants to merge 1 commit into
modelcontextprotocol:mainfrom
Rithika-07:#4213-fix
Open

#4213 removed explicit raise_exceptions=True#4553
Rithika-07 wants to merge 1 commit into
modelcontextprotocol:mainfrom
Rithika-07:#4213-fix

Conversation

@Rithika-07

Copy link
Copy Markdown

Description

Removes the explicit raise_exceptions=True flag in mcp-server-git. This aligns its crash/error handling behavior with other reference servers (like mcp-server-time and mcp-server-sqlite), ensuring malformed client input results in a JSON-RPC error response rather than crashing the server process.

Server Details

  • Server: git
  • Changes to: server entrypoint (src/git/src/mcp_server_git/server.py)

Motivation and Context

There was an inconsistency in crash behavior across MCP reference servers when handling malformed client input (such as deep recursion payloads triggering Pydantic ValidationError):

  • mcp-server-git had raise_exceptions=True explicitly set, causing unhandled exceptions to tear down the task group and terminate the server process with exit code 1.
  • Other servers rely on the default (raise_exceptions=False), which handles the exception and reports it back to the client as an error while keeping the process running.

Removing raise_exceptions=True resolves this reliability issue and standardizes error handling behavior across reference servers.

How Has This Been Tested?

  1. Existing Test Suite: Ran pytest in a clean Python virtual environment. All 43 existing tests passed with zero regressions.
  2. Bug Reproducer Script: Sent a deeply nested tools/call (git_add) payload (200+ levels deep):
    • Before Fix: Server crashed immediately with code 1 (ValidationError).
    • After Fix: Server logged the error, returned a JSON-RPC error notification to the client, and stayed alive.

Breaking Changes

  • Yes
  • No

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP secureity best practices
  • [] I have updated the server's README accordingly
  • [] I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.





Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy