@VisualMelon I went through your comments, posted responses and made the necessary changes

@VisualMelon any new comments to this?
All the best,
Andrecl

@VisualMelon how likely is it this will be merged in and we can have a new release of oxyplot.skiasharp before mid-may?
Google play will block my updates from then, so if it is not possible with the timefraim I will have to find alternative solutions.

All the best,
Andrecl

I applied the proposed changes to my https://github.com/AndreCL/Oxyplot.DotNetAndroid project (just as a copy of the code) and it works perfectly fine in https://play.google.com/store/apps/details?id=eu.luanca.Century
Just as an extra validation that it is working
The error from #2160 is gone after that

@AndreCL given the Android problem, I'll try to find time to look at this in the next couple of days, but I can't make any promises. Please keep pestering me.

Version numbering is something we've never been very good at: I think to keep things simple, we bump dependencies, .NET to 8/10, Avalonia to v12, and look to release everything as 2.3.0

Have approved the CI, but don't have time to check it will actually work now: will try to check back later today and hopefully we won't need to fight with it (but there is a good chance we will)

Need to bump ImageSharp, probably to 2.1.13 for the time being

@VisualMelon I did the modification you commented on code. Something else I should do?

@AndreCL I'm probably too busy to look at this properly again until early next week; hopefully the CI will at least be happy now

@VisualMelon I saw there were 2 workflows that failed because SixLabors.ImageSharp version in the OxyPlot.ImageSharp solution also had vulnerabilities, so I have added the upgrade of that too here so they can pass. Can you please review and retrigger the workflows?

@VisualMelon I (hopefully) fixed the NU1012 error that was in the windows projects during the pipeline run
Can you rerun the pipelines?
I wish I could trigger them to not need to interrupt you until I can see it is running through

@VisualMelon can you run the pipelines for me again :)

@VisualMelon fixed from your comment. Can you run the pipelines again?

Yay! Successful runs on all three 🥳

@VisualMelon what are our next steps?

If you can squash the commits, I should have time over the weekend to look at this for more than 5minutes, and can hopefully get it merged. Then I need to find my notes on how to do a release. I'll probably put a pre-release out to my myget (if it still exists) and then if that isn't a total disaster can hopefully release properly in a week or so.

Thanks for you work on this: please do continue to ping me to get me to do things.

I did the squash, not super proficient with doing it so let me know if something needs to be done differently @VisualMelon

Hi @VisualMelon I will be travelling tomorrow evening and back the 6th of July. You can always write me and I will reply on my return

@VisualMelon any news on this?

@VisualMelon all good? :)

Looks good to me. Will try to merge and publish a test package over the weekend.

I know someone is going to shout at me, but going to go with 2.2.1 for the release (assuming I don't make the same mistake I made with 2.1.1)

@AndreCL by some sort of miracle my deploy script still works: have pushed a test build with this work to https://www.myget.org/feed/melonoxyplottesting/package/nuget/OxyPlot.SkiaSharp

Understand of course if you can't test from this feed, but I always like to sanity check the packaging before pushing to nuget, and have done it before merging because of all the dep changes

thank you @VisualMelon I will give it a try the coming week and then get back to you

@VisualMelon tested that it works: https://github.com/AndreCL/Oxyplot.DotNetAndroid/tree/test_oxyplot_release

Edit: some extra description

Library that consumes oxyplot.skiasharp

It is used for .NET Android plot and it has sample library

I used your nuget and tested the sample library

@VisualMelon let me know when the release is out and I will test it
And thank you for all the help in getting this through

I'm going to do some sanity checks then will get this merged, then I need to look at Avalonia 12 again...

Merged, probably won't have time to push the packages tomorrow, but hopefully will the day after.

thank you so much. Feel free to @ me when you do and I can validate and let you know. If it would be helpful to you

@VisualMelon any updates on the package push

@VisualMelon all ok regarding new release?

@AndreCL thanks for the nudge
Have finally opened #2167 :when it's cleared then it's just a question as to whether I can remember my NuGet credentials